Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

renovate: not update gomodules.xyz/jsonpatch/v2 #1202

Closed
wants to merge 2 commits into from
Closed

renovate: not update gomodules.xyz/jsonpatch/v2 #1202

wants to merge 2 commits into from

Conversation

dominikholler
Copy link
Contributor

@dominikholler dominikholler commented Jan 10, 2025 •
edited
Loading

The new upcomming version of k8s.io/apimachinery would enforce an update of the golang version. So let's delay updating the dependency until we want to pick up golang 1.23 .

What this PR does / why we need it:

gomodules.xyz/jsonpatch/v2 seems to confuse renovate which lead to invalid PRs.

Which issue(s) this PR fixes:

I hope it fixes #1109 .

Special notes for your reviewer:

Release note:

NONE

@kubevirt-bot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Jan 10, 2025
@kubevirt-bot kubevirt-bot requested a review from akrejcir January 10, 2025 16:33
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign akrejcir for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot requested a review from ksimon1 January 10, 2025 16:33
@kubevirt-bot kubevirt-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XS labels Jan 10, 2025
@dominikholler
Copy link
Contributor Author

/retest-required

@ksimon1
Copy link
Member

ksimon1 commented Jan 13, 2025

Btw. not only k8s.io/apimachinery will bump the go version. The #1109 bumps other k8s dependencies too.
(https://github.com/kubernetes/client-go/blob/release-1.32/go.mod#L5
https://github.com/kubernetes/apiextensions-apiserver/blob/release-1.32/go.mod#L5
https://github.com/kubernetes/api/blob/release-1.32/go.mod#L5
https://github.com/kubernetes/kube-aggregator/blob/release-1.32/go.mod#L5)

@dominikholler
Copy link
Contributor Author

@ksimon1 I see, thanks, I checked just the api/go.mod .
So the increase of the golang version in go.mod might trigger the bug of broken version numbers, e.g. inhttps://github.com/dominikholler/ssp-operator/commit/347513719e3da2b01c2d08d5e68c97df49f88cb2#r151240651

@kubevirt-bot kubevirt-bot added dco-signoff: no Indicates the PR's author has not DCO signed all their commits. and removed dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jan 13, 2025
@dominikholler dominikholler force-pushed the main branch 3 times, most recently from 0b8f5f7 to b027b07 Compare January 17, 2025 16:30
@kubevirt-bot kubevirt-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L and removed size/XXL labels Jan 17, 2025
@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 17, 2025
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Jan 17, 2025
@dominikholler dominikholler changed the title renovate: not update k8s.io/apimachinery renovate: not update gomodules.xyz/jsonpatch/v2 Jan 17, 2025
@dominikholler
Copy link
Contributor Author

I changed the excluded dependency to gomodules.xyz/jsonpatch/v2 . Please find an example update in

dominikholler@5f4f0d1#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6

@kubevirt-bot kubevirt-bot added dco-signoff: no Indicates the PR's author has not DCO signed all their commits. and removed dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jan 21, 2025
@dominikholler
renovate: enable main
3573a39 
enable main, but disable updating gomodules.xyz/jsonpatch/v2
because of gomodules/jsonpatch#28 .

Signed-off-by: Dominik Holler <[email protected]>
@dominikholler
renovate: do not constraint go version in main
2e20e9d 
To stay in sync with kubernetes, the go version should be not
constrained.

Signed-off-by: Dominik Holler <[email protected]>
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Jan 21, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 21, 2025

@dominikholler: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-functests 2e20e9d link true /test e2e-functests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dominikholler
Copy link
Contributor Author

superseded by #1210

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akrejcir akrejcir Awaiting requested review from akrejcir

@ksimon1 ksimon1 Awaiting requested review from ksimon1

Assignees
No one assigned
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dominikholler @kubevirt-bot @ksimon1