Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v0.16] Watch required CRDs, and restart operator if they are removed #420

Conversation

kubevirt-bot
Copy link
Contributor

This is an automated cherry-pick of #417

/assign akrejcir

Operator properly handles missing CRDs.

This will make it easier to create cancellation context
in the next commit.

Signed-off-by: Andrej Krejcir <[email protected]>
Added a new component, CrdWatch, that watches CRDs in cluster.

If some of the needed CRDs are missing, the SSP reconciler runs
in a "cleanup only" mode, and does not reconcile any resources,
only deletes resources when a SSP resource is deleted.

Signed-off-by: Andrej Krejcir <[email protected]>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Oct 10, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
50.0% 50.0% Duplication

@ksimon1
Copy link
Member

ksimon1 commented Oct 10, 2022

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2022
@akrejcir
Copy link
Collaborator

/approve

@kubevirt-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akrejcir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2022
@akrejcir
Copy link
Collaborator

/retest

1 similar comment
@akrejcir
Copy link
Collaborator

/retest

@kubevirt-bot kubevirt-bot merged commit 50967aa into kubevirt:release-v0.16 Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants