Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tekton tasks manifests to version v0.13.1 #128

Merged
merged 2 commits into from
Feb 16, 2023
Merged

Update tekton tasks manifests to version v0.13.1 #128

merged 2 commits into from
Feb 16, 2023

Conversation

ksimon1
Copy link
Member

@ksimon1 ksimon1 commented Feb 14, 2023

Update tekton tasks manifests to version v0.13.1
Release note:

Update tekton tasks bundle to v0.13.1

@ksimon1
Update tekton tasks manifests to version v0.13.1
46c0076 
Signed-off-by: Kubevirt-Tekton-tasks Release Automation <[email protected]>
@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Feb 14, 2023
@openshift-ci openshift-ci bot requested review from 0xFelix and akrejcir February 14, 2023 17:26
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2023
@ksimon1
Copy link
Member Author

ksimon1 commented Feb 14, 2023

/retest

1 similar comment
@ksimon1
Copy link
Member Author

ksimon1 commented Feb 15, 2023

/retest

0xFelix
0xFelix approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix, ksimon1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ksimon1
Copy link
Member Author

ksimon1 commented Feb 16, 2023

/test win2k22-pipeline-example-test

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 16, 2023

@ksimon1: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test e2e-functests
  • /test images
  • /test unittests
  • /test win10-pipeline-example-test
  • /test win11-pipeline-example-test
  • /test win2k22-pipeline-example-test

Use /test all to run all jobs.

In response to this:

/test win10-pipeline-example-tes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ksimon1
Copy link
Member Author

ksimon1 commented Feb 16, 2023

/test win10-pipeline-example-test

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2023
@ksimon1
Copy link
Member Author

ksimon1 commented Feb 16, 2023

/test win11-pipeline-example-test

0xFelix
0xFelix reviewed Feb 16, 2023
View reviewed changes
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please give a little more context in the commit descriptions why a revert to KubeVirt 0.58.0 was necessary?

@ksimon1 ksimon1 force-pushed the update-tekton-tasks-manifests-v0.13.1 branch from fb0c15b to 4ff14ee Compare February 16, 2023 13:50
@ksimon1
fix: revert kubevirt version back to v0.58.0
c891a17 
Kubevirt v0.58.1 and 0.59.0-rc.0 probably contains bug, which is causing
that windows vm is in pending state. The virt-launcher is in unschedulable
state (probably due to TSC node selector). Test lanes, which are testing
example pipelines are failing due to that issue. Reverting kubevirt
version back will fix the test lanes, until the issue is fixed in
kubevirt project.
Signed-off-by: Karel Šimon <[email protected]>
@ksimon1 ksimon1 force-pushed the update-tekton-tasks-manifests-v0.13.1 branch from 4ff14ee to c891a17 Compare February 16, 2023 15:19
@0xFelix
Copy link
Member

0xFelix commented Feb 16, 2023

/lgtm

Thanks!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2023
@ksimon1 ksimon1 merged commit 8fbe0a0 into kubevirt:main Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFelix 0xFelix 0xFelix approved these changes

@akrejcir akrejcir Awaiting requested review from akrejcir

Assignees

@0xFelix 0xFelix

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ksimon1 @0xFelix @kubevirt-bot