Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constants rework #5

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Constants rework #5

merged 1 commit into from
Apr 15, 2024

Conversation

pyctrl
Copy link
Collaborator

@pyctrl pyctrl commented Apr 11, 2024

No description provided.

@pyctrl pyctrl requested a review from kuderr April 11, 2024 14:19
kuderr
kuderr reviewed Apr 13, 2024
View reviewed changes
netsome/constants.py Outdated Show resolved Hide resolved
kuderr
kuderr reviewed Apr 14, 2024
View reviewed changes
netsome/constants.py Outdated Show resolved Hide resolved
kuderr
kuderr reviewed Apr 14, 2024
View reviewed changes
netsome/_converters/bgp.py Outdated Show resolved Hide resolved
kuderr
kuderr reviewed Apr 14, 2024
View reviewed changes
netsome/_converters/bgp.py Outdated Show resolved Hide resolved
kuderr
kuderr reviewed Apr 14, 2024
View reviewed changes
netsome/_converters/bgp.py Outdated Show resolved Hide resolved
kuderr
kuderr reviewed Apr 14, 2024
View reviewed changes
netsome/constants.py Outdated Show resolved Hide resolved
kuderr
kuderr reviewed Apr 14, 2024
View reviewed changes
netsome/constants.py Outdated Show resolved Hide resolved
kuderr
kuderr reviewed Apr 14, 2024
View reviewed changes
netsome/constants.py Outdated Show resolved Hide resolved
kuderr
kuderr reviewed Apr 14, 2024
View reviewed changes
netsome/constants.py Outdated Show resolved Hide resolved
kuderr
kuderr reviewed Apr 14, 2024
View reviewed changes
netsome/validators/ipv4.py Outdated Show resolved Hide resolved
kuderr
kuderr reviewed Apr 14, 2024
View reviewed changes
netsome/types/vlans.py Outdated Show resolved Hide resolved
kuderr
kuderr reviewed Apr 14, 2024
View reviewed changes
netsome/validators/ipv4.py Outdated Show resolved Hide resolved
kuderr
kuderr approved these changes Apr 15, 2024
View reviewed changes
Copy link
Owner

@kuderr kuderr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imba

@kuderr kuderr changed the title Constants discussion Constants rework Apr 15, 2024
@kuderr kuderr merged commit adb5630 into master Apr 15, 2024
1 check passed
@kuderr kuderr deleted the const-discuss branch April 15, 2024 06:59
kuderr pushed a commit that referenced this pull request Apr 15, 2024
@pyctrl @kuderr
Constants rework (#5)
1b20496
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuderr kuderr kuderr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pyctrl @kuderr