Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made three changes to test
describe-locks
more throughout:DescribeLocks
now returns a sorted slice ofProjectDesc
, which is also a collection of sortedPhaseDesc
s.Previously, project and phase ordering within a
describe-locks
response was dependent on how the underlying Gomap
stored and returned projects and phases, which resulted in flaky test when we had to testdescribe-locks
with multiple projects and phases.This fixes that by sorting projects and phases before generating a response.
myproject1
. Now we test with two.production
. We now havestaging
too.