Fix @bot describe locks to get triggered
#1148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mumoshu
force-pushed
the
fix-describe-locks
branch
from
1238306 to
b28b007
Compare
pirlodog1125
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mainly fixes
parseDescribeLocksin the implementation to makedescribe locksactually usable.Previously, the command has never been triggered when you say
@bot describe-locks, because the function was not taking into account that mentions to the bot contains text prefixed by the bot user ID.This PR also tweaks the test so that test data contains the bot user ID as prefixes in the mentioned texts, along with adding support for CONFIG_NAMESPACE in the test, allowing you to configure which k8s namespace to use in the test.