Fix lock/unlock error message for unknown user #1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
K-Bokka
approved these changes
Oct 8, 2024
pirlodog1125
approved these changes
Oct 8, 2024
pirlodog1125
force-pushed
the
fix-unknown-user-err-msg
branch
from
2bb597e to
06faddb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
you are not allowed to lock/unlock projectserror message sent when you tried to lock/unlock a project/phase contained the Slack user ID likeU123456.The intention was that you could use it to update the user list configmap to include the Slack user, to have the Developer role, so that you are able to lock/unlock the project.
However, the user list uses Slack display name instead of the user ID for identifying the user, which makes user ID useless! Let me change it to include the display name, so that a gocat admin can use it to update the user list.