Use needsManualCrop with needsOriginal #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuhei-kaneko
changed the title
fukajun
approved these changes
Aug 23, 2023
shuhei-kaneko
force-pushed
the
Use-needsManualCrop-and-needsOriginal
branch
from
63e6da3 to
d5d605b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background & Changes
Add option to use o (original image) when mc (manual crop).
Specifically, allow the condition mc = true, o=true
Until now, when mc = true, the size of the image to be acquired was determined by the values of the parameters w and h
e.g. When w=300,h=300, size=1000 was recognized and the non-original image was selected.
https://github.com/tokubai/kinu/blob/master/resource/backward_compatible.go#L37-L43
Change Imagemagick download link in Dockerfile.