feat: again load source fail should catch error #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
qiYuei
commented
Sep 21, 2023
•
qiYuei
commented
- resolve qiankun劫持的资源首次加载失败后,后续加载都不会触发资源的 error事件 umijs/qiankun#2696
This was referenced Sep 21, 2023
kuitos
requested changes
Oct 9, 2023
| @@ -246,6 +246,9 @@ export function execScripts(entry, scripts, proxy = window, opts = {}) { | |||
| } | |||
|
|
|||
| return new Promise(resolve => schedule(0, success || resolve)); | |||
| }).catch((e) => { | |||
| error(); | |||
There was a problem hiding this comment.
这里 catch 的话 getExternalScripts 那里就不要再 catch 了，不然 error callback 会被调用两次
kuitos
requested changes
Oct 10, 2023
src/index.js
Outdated
| errorCallback(); | ||
| throw e; | ||
| })); | ||
| })) |
kuitos
reviewed
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.