Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: uploads Cypress screenshots and videos on failure #1178

Merged
merged 1 commit into from
Jul 14, 2023
Merged

ci: uploads Cypress screenshots and videos on failure #1178

merged 1 commit into from
Jul 14, 2023

Conversation

kleinfreund
Copy link
Contributor

@kleinfreund kleinfreund commented Jul 14, 2023

Uploads Cypress screenshots and videos on failure of the test run.

Signed-off-by: Philipp Rudloff [email protected]

Workflow run summary in failure case (has uploaded artifacts): https://github.com/kumahq/kuma-gui/actions/runs/5552202267

Workflow run summary in success case (doesn't have uploaded artifacts): https://github.com/kumahq/kuma-gui/actions/runs/5552247266?pr=1178

Uploads Cypress screenshots and videos on failure of the test run.

Signed-off-by: Philipp Rudloff <[email protected]>
@kleinfreund kleinfreund self-assigned this Jul 14, 2023
@netlify
Copy link

netlify bot commented Jul 14, 2023

Deploy Preview for kuma-gui ready!

Name Link
🔨 Latest commit 290d2a0
🔍 Latest deploy log https://app.netlify.com/sites/kuma-gui/deploys/64b10b03b48de200086e5bbc
😎 Deploy Preview https://deploy-preview-1178--kuma-gui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kleinfreund kleinfreund marked this pull request as ready for review July 14, 2023 08:44
@kleinfreund kleinfreund requested a review from a team as a code owner July 14, 2023 08:44
@kleinfreund kleinfreund requested review from johncowen and removed request for a team July 14, 2023 08:44
Copy link
Contributor

@johncowen johncowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM!

Just a tiny thing if you could take a quick look, is there a way to open the web inspector so we can see that also. I guess not? But might be worth taking a quick look incase? lmk

(oh and thanks for posting a link to the fails 👍 )

@kleinfreund
Copy link
Contributor Author

@johncowen From looking at cypress-io/cypress#2024, this seems technically possible but has issues with actually capturing the content on the dev tools.

@johncowen
Copy link
Contributor

This seems technically possible but has issues with actually capturing the content on the dev tools.

Would be good to sort this at some point, or keep an eye on the issue if its an upstream problem

@kleinfreund kleinfreund merged commit 882d60e into kumahq:master Jul 14, 2023
@kleinfreund kleinfreund deleted the ci/upload-cypress-artifacts branch July 14, 2023 10:15
@kleinfreund kleinfreund removed their assignment Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants