Feature/config extension #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/kumuluzee into feature/config-extension
…/kumuluzee into feature/config-extension # Conflicts: # core/src/main/java/com/kumuluz/ee/EeApplication.java # core/src/main/java/com/kumuluz/ee/loaders/ExtensionLoader.java
TFaga
requested changes
May 12, 2017
| } | ||
|
|
||
| public void unsubscribe(ConfigurationListener listener) { | ||
| config.getDispatcher().unsubscribe(listener); | ||
| } | ||
|
|
||
| public void notifyChange(String key, String value) { |
There was a problem hiding this comment.
Remove this method in the util in order to not allow anyone to publish changes to the config. Instead pass the ConfigurationDispatcher instance to the ConfigurationSource and make sure the source calls notify on that instance.
| .getDeclaredAnnotation(EeExtensionDef.class).type().equals(EeExtensionType.CONFIG)).collect | ||
| (Collectors.toList()); | ||
|
|
||
| for (Extension configExtension : configExtensions) { |
There was a problem hiding this comment.
Additionally check if the extension contains a list of required Ee dependencies and validate if they are fulfilled.
| (Collectors.toList()); | ||
|
|
||
| log.info("Initialising non-config extensions"); | ||
| for (Extension extension : otherExtensions) { |
There was a problem hiding this comment.
Same as above for the config extensions.
TFaga
approved these changes
May 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.