Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

capital-game #4832

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

capital-game #4832

wants to merge 3 commits into from

Conversation

nadarmega
Copy link

@nadarmega nadarmega commented Jul 12, 2024

PR Description 📜

Please include summary related to the issue you have fixed and describe your PR in brief over here by specifying the issue number on which you were working below
Fixes # <your_issue_number>


Mark the task you have completed ✅

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for website preview in assets/images
  • I have added entries for my game in main README.md
  • I have added README.md in my folder
  • I have added working video of the game in README.md (optional)
  • I have specified the respective issue number for which I have requested the new game.

Screenshots:

Screenshot 2024-07-12 170758
Screenshot 2024-07-12 170920



Thank you soo much for contributing to our repository 💗

@kunjgit
Copy link
Owner

kunjgit commented Jul 12, 2024

Thank you @nadarmega ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@nadarmega
Copy link
Author

@kunjgit please review my code!

Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do the following updates in your pr
add your game entry in main readme.md file of the repo refer other entries for the format
add image of your game in the asset folder of the repo follow naming convention while naming the image

@nadarmega
Copy link
Author

@ishita-43 changes have been made! All good?

@nadarmega
Copy link
Author

@ishita-43 @kunjgit changes have been pushed!

@nadarmega
Copy link
Author

Please review @ishita-43

@ishita-43
Copy link
Collaborator

Please review @ishita-43

You will find readme file on gamezone repo in same hierarchy as games folder where you placed your game and also asset folder as games asset readme contribution. Md files you need to make there on that readme me file refer other pr for the format and how they did that. If still confused ask me again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants