Skip to content

Commit

Permalink
added id's to action and cancel buttons in modal for e2e (#760)
Browse files Browse the repository at this point in the history
  • Loading branch information
alexkhalevine authored Apr 6, 2020
1 parent 2a28019 commit 2e098b7
Show file tree
Hide file tree
Showing 12 changed files with 71 additions and 13 deletions.
56 changes: 56 additions & 0 deletions .bitmap
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
/* THIS IS A BIT-AUTO-GENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY. */

{
"button": {
"files": [
{
"relativePath": "src/components/Button/customTheme.scss",
"test": false,
"name": "customTheme.scss"
},
{
"relativePath": "src/components/Button/index.jsx",
"test": false,
"name": "index.jsx"
},
{
"relativePath": "src/components/Button/index.scss",
"test": false,
"name": "index.scss"
},
{
"relativePath": "src/components/Button/story.js",
"test": false,
"name": "story.js"
}
],
"mainFile": "src/components/Button/index.jsx",
"trackDir": "src/components/Button",
"origin": "AUTHORED",
"exported": false
},
"theme-provider": {
"files": [
{
"relativePath": "src/components/ThemeProvider/ThemeProvider.jsx",
"test": false,
"name": "ThemeProvider.jsx"
},
{
"relativePath": "src/components/ThemeProvider/index.js",
"test": false,
"name": "index.js"
},
{
"relativePath": "src/components/ThemeProvider/story.js",
"test": false,
"name": "story.js"
}
],
"mainFile": "src/components/ThemeProvider/index.js",
"trackDir": "src/components/ThemeProvider",
"origin": "AUTHORED",
"exported": false
},
"version": "14.7.2"
}
2 changes: 1 addition & 1 deletion docs/iframe.html
Original file line number Diff line number Diff line change
Expand Up @@ -57,4 +57,4 @@
console.warn('unable to connect to parent frame for connecting dev tools');
}</script></head><body><div class="sb-nopreview sb-wrapper"><div class="sb-nopreview_main"><h1 class="sb-nopreview_heading sb-heading">No Preview</h1><p>Sorry, but you either have no stories or none are selected somehow.</p><ul><li>Please check the storybook config.</li><li>Try reloading the page.</li></ul></div></div><div class="sb-errordisplay sb-wrapper"><div id="error-message" class="sb-heading"></div><pre class="sb-errordisplay_code">
<code id="error-stack"></code>
</pre></div><div id="root"></div><script src="runtime~main.1b0c21b9ba98df97c73a.bundle.js"></script><script src="vendors~main.1b0c21b9ba98df97c73a.bundle.js"></script><script src="main.1b0c21b9ba98df97c73a.bundle.js"></script></body></html>
</pre></div><div id="root"></div><script src="runtime~main.7ce8bdd34f5e7d8b74c6.bundle.js"></script><script src="vendors~main.7ce8bdd34f5e7d8b74c6.bundle.js"></script><script src="main.7ce8bdd34f5e7d8b74c6.bundle.js"></script></body></html>
2 changes: 1 addition & 1 deletion docs/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -80,4 +80,4 @@
c1.2,1.5,0.7,3.5,0.7,3.5c-0.7,2.9,1,4.3,2.3,4.9l0.3-0.3c1-0.8,2-1,2.7-1c-2.7-3.4-4.7-7.7,0.5-13c1.5-1.5,3.3-2.2,5.1-2.2
c0.2-0.5,1.1-2.4,3.7-3.5c0,0,1.5,0.8,2.4,5.2c1.4,0.8,2.7,1.8,3.9,2.9c1.2,1.2,2.2,2.5,2.9,3.9c4.4,0.8,5.2,2.3,5.2,2.3
c-1.2,2.6-3,3.6-3.5,3.7c-0.1,1.9-0.8,3.6-2.3,5.1c-5.2,5.2-9.6,3.2-13,0.5c0.1,0.9-0.3,2.2-1.6,3.5l-3.7,3.7
c-0.2,0.2-0.1,0.5-0.1,0.9l0.4,0.9L-135,297v-80H-215z"/></g></svg></a><script>document.title = 'Nukleus';</script></head><body><div id="root"></div><script src="./sb_dll/storybook_ui_dll.js"></script><script src="runtime~main.6ac4c33d73ae9704bbb9.bundle.js"></script><script src="vendors~main.cb5c643f9844dad244c3.bundle.js"></script><script src="main.29d295f6af76d587efb4.bundle.js"></script></body></html>
c-0.2,0.2-0.1,0.5-0.1,0.9l0.4,0.9L-135,297v-80H-215z"/></g></svg></a><script async src="https://cdn.polyfill.io/v2/polyfill.min.js?features=default,IntersectionObserver,Array.prototype.includes,Array.prototype.find,Array.prototype.findIndex,Intl.~locale.de,Intl.~locale.at,Intl.~locale.en,Intl.~locale.ch"><script>document.title = 'Nukleus';</script></head><body><div id="root"></div><script src="./sb_dll/storybook_ui_dll.js"></script><script src="runtime~main.6ac4c33d73ae9704bbb9.bundle.js"></script><script src="vendors~main.cb5c643f9844dad244c3.bundle.js"></script><script src="main.29d295f6af76d587efb4.bundle.js"></script></body></html>
2 changes: 0 additions & 2 deletions docs/main.1b0c21b9ba98df97c73a.bundle.js

This file was deleted.

2 changes: 2 additions & 0 deletions docs/main.7ce8bdd34f5e7d8b74c6.bundle.js

Large diffs are not rendered by default.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions src/components/Modal/index.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ export default class Modal extends React.Component {
onClick={this.onAction}
text={actionText}
type="primary"
id="nukleus-modal-action-btn"
/>
)}
{cancelText && (
Expand All @@ -92,6 +93,7 @@ export default class Modal extends React.Component {
onClick={this.onExit}
text={cancelText}
type="secondary"
id="nukleus-modal-cancel-btn"
/>
)}
</footer>
Expand Down
Loading

0 comments on commit 2e098b7

Please sign in to comment.