Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fleet: implement buckup plugin #381

Merged
merged 6 commits into from
Sep 15, 2023
Merged

fleet: implement buckup plugin #381

merged 6 commits into from
Sep 15, 2023

Conversation

Xieql
Copy link
Contributor

@Xieql Xieql commented Sep 7, 2023

What type of PR is this?

/kind cleanup
/kind feature

What this PR does / why we need it:

support for installing Velero in multi-cluster as a union by applying Fleet, which involves setting up the backup plugin.

part of #374

the api implement of #378

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

support union install velero by apply fleet whoes backup plugin is set.

@netlify
Copy link

netlify bot commented Sep 7, 2023 •
edited
Loading

✅ Deploy Preview for kurator-dev canceled.

Name Link
🔨 Latest commit d866d74
🔍 Latest deploy log https://app.netlify.com/sites/kurator-dev/deploys/6503fc8246d33e0008223ee4

@Xieql Xieql force-pushed the implement-velero-plugin branch from ebdbe98 to 18a1cf0 Compare September 7, 2023 12:16
hzxuzhonghu
hzxuzhonghu reviewed Sep 7, 2023
View reviewed changes
Copy link
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering reconcile the plugins concurrently, because reconcile them one by one maybe too time costing

@Xieql
Copy link
Contributor Author

Xieql commented Sep 7, 2023 •
edited
Loading

Wondering reconcile the plugins concurrently, because reconcile them one by one maybe too time costing

yes, currentlly, each plugin need wait for plugin helm release to be reconciled

@Xieql Xieql force-pushed the implement-velero-plugin branch from 18a1cf0 to 7c0a653 Compare September 7, 2023 12:46
@Xieql Xieql marked this pull request as draft September 11, 2023 07:22
hzxuzhonghu
hzxuzhonghu reviewed Sep 12, 2023
View reviewed changes
Copy link
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add more test cases

@Xieql
Copy link
Contributor Author

Xieql commented Sep 13, 2023

Could you add more test cases

ok

@Xieql Xieql force-pushed the implement-velero-plugin branch from f1434b9 to 9168874 Compare September 13, 2023 07:36
@Xieql
Copy link
Contributor Author

Xieql commented Sep 13, 2023

still in draft.
the draft label will be removed when this pr is ready

@Xieql
update
b0bdae6 
Signed-off-by: Xieql <[email protected]>
@Xieql Xieql force-pushed the implement-velero-plugin branch from 9168874 to b0bdae6 Compare September 14, 2023 08:58
@Xieql Xieql marked this pull request as ready for review September 14, 2023 09:01
@Xieql
Copy link
Contributor Author

Xieql commented Sep 14, 2023

/label tide/merge-method-squash

@Xieql
Copy link
Contributor Author

Xieql commented Sep 14, 2023

PTAL @hzxuzhonghu

hzxuzhonghu
hzxuzhonghu reviewed Sep 14, 2023
View reviewed changes
pkg/fleet-manager/fleet_plugin_backup.go Outdated Show resolved Hide resolved
pkg/fleet-manager/fleet_plugin_backup.go Outdated Show resolved Hide resolved
pkg/fleet-manager/fleet_plugin_backup.go Outdated Show resolved Hide resolved
@Xieql
update
2458d24 
Signed-off-by: Xieql <[email protected]>
hzxuzhonghu
hzxuzhonghu reviewed Sep 15, 2023
View reviewed changes
pkg/fleet-manager/fleet_plugin.go Outdated
@@ -38,7 +38,7 @@ const (

NoneClusterIP = "None"

FleetPluinLabel = "fleet.kurator.dev/fleet-plugin"
FleetPluinLabel = "fleet.kurator.dev/plugin-typo"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

Copy link
Contributor Author

@Xieql Xieql Sep 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found this name already been defined
see https://github.com/kurator-dev/kurator/blob/5734bb72d2d0a2b8fc00d974e41da5f17560240a/pkg/fleet-manager/util.go#L31C1-L31C1
so I deside to remove it

@kurator-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Xieql
update
d866d74 
Signed-off-by: Xieql <[email protected]>
hzxuzhonghu
hzxuzhonghu reviewed Sep 15, 2023
View reviewed changes
Copy link
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kurator-bot kurator-bot merged commit 76fcb95 into kurator-dev:main Sep 15, 2023
@Xieql Xieql mentioned this pull request Oct 11, 2023
Merged
@Xieql Xieql mentioned this pull request Oct 19, 2023
Closed
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzxuzhonghu hzxuzhonghu hzxuzhonghu approved these changes

@kevin-wangzefeng kevin-wangzefeng Awaiting requested review from kevin-wangzefeng

@zirain zirain Awaiting requested review from zirain

Assignees

@hzxuzhonghu hzxuzhonghu

Labels
approved kind/cleanup kind/feature lgtm size/XL tide/merge-method-squash
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Xieql @kurator-bot @hzxuzhonghu