Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add crd:allowDangerousTypes=true in update-crdgen.sh #507

Merged

Conversation

LiZhenCheng9527
Copy link
Contributor

What this PR does / why we need it:
Make gen will failed When a field defined in CRDs contains float. In order to generate crd properly, I add crd:allowDangerousTypes=true in update-crdgen.sh.

Copy link

netlify bot commented Dec 8, 2023

Deploy Preview for kurator-dev canceled.

Name Link
🔨 Latest commit 75d179a
🔍 Latest deploy log https://app.netlify.com/sites/kurator-dev/deploys/65727a4531b3c400089e8bf2

Copy link
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kurator-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kurator-bot kurator-bot merged commit a704ef2 into kurator-dev:main Dec 8, 2023
9 checks passed
@LiZhenCheng9527 LiZhenCheng9527 deleted the change-update-codegen branch January 29, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants