Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update readme for fix markdown lint #512

Merged
merged 2 commits into from
Dec 12, 2023
Merged

update readme for fix markdown lint #512

merged 2 commits into from
Dec 12, 2023

Conversation

Xieql
Copy link
Contributor

@Xieql Xieql commented Dec 11, 2023 •
edited
Loading

What type of PR is this?

/kind bug
/kind documentation

What this PR does / why we need it:

fixed markdown lint error by adding missing alternate text for images.

see

markdownlint docs --ignore docs/content/en/references --ignore docs/node_modules -c common/config/mdl.json
markdownlint ./README.md -c common/config/mdl.json
./README.md:33:5 MD045/no-alt-text Images should have alternate text (alt text)

@netlify Netlify
Copy link

netlify bot commented Dec 11, 2023 •
edited
Loading

✅ Deploy Preview for kurator-dev canceled.

Name Link
🔨 Latest commit b25e8d2
🔍 Latest deploy log https://app.netlify.com/sites/kurator-dev/deploys/6577b52e4938b200087d4eea

@Xieql
Copy link
Contributor Author

Xieql commented Dec 11, 2023

/kind documentation

@Xieql
Copy link
Contributor Author

Xieql commented Dec 11, 2023

@hzxuzhonghu PTAL, without addressing this issue, all other PRs will encounter check failures."

@Xieql
Copy link
Contributor Author

Xieql commented Dec 11, 2023

Fixes #514

zirain
zirain reviewed Dec 11, 2023
View reviewed changes
README.md Outdated
@@ -30,7 +30,7 @@ It provides powerful capabilities for multi-cloud and multi-cluster management,
## Architecture

<div align="center">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not use markdown sytnax?

Copy link
Contributor Author

@Xieql Xieql Dec 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@Xieql
Copy link
Contributor Author

Xieql commented Dec 12, 2023

/label tide/merge-method-squash

hzxuzhonghu
hzxuzhonghu approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kurator-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kurator-bot kurator-bot merged commit 40eb58e into kurator-dev:main Dec 12, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zirain zirain zirain left review comments

@hzxuzhonghu hzxuzhonghu hzxuzhonghu approved these changes

Assignees

@hzxuzhonghu hzxuzhonghu

Labels
approved kind/bug kind/documentation lgtm size/XS tide/merge-method-squash
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Xieql @kurator-bot @zirain @hzxuzhonghu