pipeline: add render pipeline func #548
Conversation
Signed-off-by: Xieql <[email protected]>
✅ Deploy Preview for kurator-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| // Define task name and reference | ||
| fmt.Fprintf(&taskBuilder, "- name: %s\n taskRef:\n name: %s\n", taskName, taskRefer) | ||
|
|
||
| // Specify dependency on the preceding task | ||
| fmt.Fprintf(&taskBuilder, " runAfter: [\"%s\"]\n", lastTask) | ||
|
|
||
| // Add fixed workspace configuration | ||
| taskBuilder.WriteString(" workspaces:\n - name: source\n workspace: kurator-pipeline-shared-data\n") | ||
|
|
||
| // Add additional workspaces if any additionalWorkspaces exist | ||
| for _, workspace := range additionalWorkspaces { | ||
| taskBuilder.WriteString(workspace) |
There was a problem hiding this comment.
This is hard to understand and later maintainence
There was a problem hiding this comment.
Is there a structure, otherwise I would suggest we add a tmplate
There was a problem hiding this comment.
You are right, and I had indeed considered whether to refactor this part before. But since it has been brought up, I will refactor this part of the code.
Signed-off-by: Xieql <[email protected]>
|
/label tide/merge-method-squash |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
What type of PR is this?
/kind feature
What this PR does / why we need it:
part of #493
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: