Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipeline: fix render rbac for chain secret #553

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

Xieql
Copy link
Contributor

@Xieql Xieql commented Jan 10, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

The chain-credentials in service account should be a optional filed,

we need it only when we have push image task.

Copy link

netlify bot commented Jan 10, 2024

Deploy Preview for kurator-dev canceled.

Name Link
🔨 Latest commit 9411f11
🔍 Latest deploy log https://app.netlify.com/sites/kurator-dev/deploys/659e4337b9fa29000852d105

Copy link
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kurator-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kurator-bot kurator-bot merged commit ff166a2 into kurator-dev:main Jan 11, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants