adds the ability to delete resources created by a Rollout. #557
Conversation
✅ Deploy Preview for kurator-dev canceled.
|
LiZhenCheng9527
force-pushed
the
rollout-delete
branch
from
9d80642 to
609f8e8
Compare
| @@ -167,6 +167,48 @@ func (a *ApplicationManager) syncRolloutPolicyForCluster(ctx context.Context, | |||
| return ctrl.Result{}, nil | |||
| } | |||
|
|
|||
| func (a *ApplicationManager) deleteResourcesInClusters(ctx context.Context, app *applicationapi.Application, fleet *fleetapi.Fleet) error { | |||
There was a problem hiding this comment.
deleteResourcesInClusters is to remove resources in member cluster?
If so i would rename it to deleteResourcesInMemberClusters
| func (a *ApplicationManager) deleteResourcesInClusters(ctx context.Context, app *applicationapi.Application, fleet *fleetapi.Fleet) error { | ||
| log := ctrl.LoggerFrom(ctx) | ||
|
|
||
| for _, syncPolicy := range app.Spec.SyncPolicies { |
There was a problem hiding this comment.
maybe it is handled in other place， but here i cannot see how we delete the resources when we update application by removing SyncPolicies
There was a problem hiding this comment.
Based on our existing framework, when deleting the SyncPolicies of an application, there is no corresponding deletion operation for its underlying resources. We should probably address this issue in future versions.
Signed-off-by: LiZhenCheng9527 <[email protected]>
LiZhenCheng9527
force-pushed
the
rollout-delete
branch
from
609f8e8 to
ceeddc3
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
adds the ability to delete resources created by a Rollout.
Which issue(s) this PR fixes:
Fixes #435