Enable fit option when the label is overflowing the rectangle #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurkle
reviewed
Jan 24, 2023
| } | ||
| return true; | ||
| } | ||
|
|
||
| function getFontFromOptions(rect, labels) { | ||
| const {font, hoverFont} = labels; | ||
| const optFont = (rect.active ? hoverFont : font) || font; |
There was a problem hiding this comment.
I think I'm going in circles, but again was it so that the sub-objects (labels in this case) don't automatically resolve the hover options?
There was a problem hiding this comment.
Yes @kurkle
There was also an issue that we closed with a patch. Hover font seems not solved. But tomorrow I want to understand better the current logic in chartjs and why is not applied here for font. Ok for you?
There was a problem hiding this comment.
Sure, but I'll merge this already anyway :)
There was a problem hiding this comment.
@kurkle please, don't hate me if you can... when you have time, we should go ahead with PRs on the annotation, I think...
kurkle
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could fix #67.
This PR is adding new possible value,
'fit', foroverflowoption.TODO