fix: restart APICs containers when the engine is restarted #2441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoporoli
commented
May 8, 2024
...ngine-lib/lib/backend_impls/docker/docker_kurtosis_backend/engine_functions/create_engine.go
Show resolved
Hide resolved
leoporoli
commented
May 8, 2024
tedim52
approved these changes
May 9, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 9, 2024
🤖 I have created a release *beep* *boop* --- ## [0.89.8](0.89.7...0.89.8) (2024-05-09) ### Features * added api for alias deletion ([#2439](#2439)) ([cf464cf](cf464cf)) ### Bug Fixes * clarify error message for kurtosis portal command ([#2433](#2433)) ([75a730b](75a730b)) * restart APICs containers when the engine is restarted ([#2441](#2441)) ([e93f3f2](e93f3f2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing the issue when running the
kurtosis engine restart --restart-apic-containers. The issue was happening when the Engine's REST API was trying to reconnect to all the enclaves while the APIC containers were in the restart process.We are also increasing the engine's readiness check time because the restart process could take more than 1 minutes if there are many APIC containers running
REMINDER: Tag Reviewers, so they get notified to review
Is this change user facing?
YES
References (if applicable)
This is part of the
upgrade kurtosis from the UIproject