Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clarify error message for kurtosis portal command #2433

Merged
merged 1 commit into from
May 8, 2024

Conversation

skylarmb
Copy link
Contributor

@skylarmb skylarmb commented May 7, 2024

Description

In certain cases, the kurtosis portal may not be able to reach your cloud instance. In this case a kurtosis run command may output an error that suggests checking the health of your kurtosis portal

[...]
Make sure Kurtosis Portal is running locally with 'kurtosis portal status' and
potentially 'kurtosis portal start'. If it is, make sure the remote server is
running and healthy

Running kurtosis portal status results in a slightly misleading error message, for example:

Kurtosis Portal process is on PID 4615 but it is unreachable

it is unreachable suggests there is an issue with with kurtosis portal process when in reality there is an issue with the cloud instance being unreachable. This PR improves the error message.

Is this change user facing?

YES

References (if applicable)

@skylarmb skylarmb requested a review from laurentluce May 7, 2024 18:20
@skylarmb skylarmb added this pull request to the merge queue May 8, 2024
Merged via the queue into main with commit 75a730b May 8, 2024
62 checks passed
@skylarmb skylarmb deleted the sb-improve-portal-error branch May 8, 2024 16:07
github-merge-queue bot pushed a commit that referenced this pull request May 9, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.89.8](0.89.7...0.89.8)
(2024-05-09)


### Features

* added api for alias deletion
([#2439](#2439))
([cf464cf](cf464cf))


### Bug Fixes

* clarify error message for kurtosis portal command
([#2433](#2433))
([75a730b](75a730b))
* restart APICs containers when the engine is restarted
([#2441](#2441))
([e93f3f2](e93f3f2))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: kurtosisbot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants