feat: adding enclave production mode value in the APIC primitive #2407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h4ck3rk3y
approved these changes
Apr 29, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 30, 2024
🤖 I have created a release *beep* *boop* --- ## [0.89.1](0.89.0...0.89.1) (2024-04-30) ### Features * adding enclave production mode value in the APIC primitive ([#2407](#2407)) ([86acc7f](86acc7f)) * set service image in em ui ([#2406](#2406)) ([917f011](917f011)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 30, 2024
🤖 I have created a release *beep* *boop* --- ## [0.89.1](0.89.0...0.89.1) (2024-04-30) ### Features * adding enclave production mode value in the APIC primitive ([#2407](#2407)) ([86acc7f](86acc7f)) * set service image in em ui ([#2406](#2406)) ([917f011](917f011)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
production modevalue is already in theenclaveprimitive but we also want to add it in theAPICprimitive this way we will be able to get this data just by calling thekurtosisBackend.GetAPIContainers()instead of having to call thekurtosisBackend.GetEnclaves()which will demand more internal backend calls, and also because this data is stored in the APIC´s env vars.Adding it only in the Docker backend because production mode is not implemented in Kubernetes yet.
REMINDER: Tag Reviewers, so they get notified to review
Is this change user facing?
NO
References (if applicable)
This is part of the "Upgrade Kurtosis from the Cloud UI project"