Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update image UI arg parsing #2419

Merged
merged 12 commits into from
May 2, 2024
Merged

fix: update image UI arg parsing #2419

merged 12 commits into from
May 2, 2024

Conversation

tedim52
Copy link
Contributor

@tedim52 tedim52 commented May 1, 2024

Description

Fixes how args are parsed and passing into script that updates images. Also fixes logic with how initialSerializedParams are set.

Is this change user facing?

NO

References

#2406

@tedim52 tedim52 force-pushed the tedi/setserviceuifix branch from 3d14dc1 to b0ed90b Compare May 1, 2024 18:15
@tedim52 tedim52 changed the title fix: set service arg parsing fix: set service UI arg parsing May 1, 2024
@tedim52 tedim52 changed the title fix: set service UI arg parsing fix: update image UI arg parsing May 1, 2024
@tedim52 tedim52 requested a review from h4ck3rk3y May 1, 2024 19:49
@tedim52 tedim52 enabled auto-merge May 2, 2024 11:00
@tedim52 tedim52 disabled auto-merge May 2, 2024 11:21
@tedim52 tedim52 force-pushed the tedi/setserviceuifix branch from 7c58aed to ed0affe Compare May 2, 2024 12:13
@tedim52 tedim52 enabled auto-merge May 2, 2024 12:15
@tedim52 tedim52 added this pull request to the merge queue May 2, 2024
Merged via the queue into main with commit cd3d928 May 2, 2024
52 checks passed
@tedim52 tedim52 deleted the tedi/setserviceuifix branch May 2, 2024 12:40
github-merge-queue bot pushed a commit that referenced this pull request May 2, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.89.3](0.89.2...0.89.3)
(2024-05-02)


### Features

* new feature to restart the API containers after the Kurtosis engine is
started ([#2413](#2413))
([494357f](494357f))


### Bug Fixes

* set service idempotency logic
([#2422](#2422))
([cbd68bf](cbd68bf))
* update image UI arg parsing
([#2419](#2419))
([cd3d928](cd3d928))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: kurtosisbot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants