-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update image UI arg parsing #2419
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tedim52
force-pushed
the
tedi/setserviceuifix
branch
from
May 1, 2024 18:15
3d14dc1
to
b0ed90b
Compare
tedim52
commented
May 1, 2024
enclave-manager/web/packages/app/src/emui/enclaves/components/widgets/ImageButton.tsx
Show resolved
Hide resolved
tedim52
changed the title
fix: set service UI arg parsing
fix: update image UI arg parsing
May 1, 2024
h4ck3rk3y
approved these changes
May 2, 2024
tedim52
force-pushed
the
tedi/setserviceuifix
branch
from
May 2, 2024 12:13
7c58aed
to
ed0affe
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 2, 2024
🤖 I have created a release *beep* *boop* --- ## [0.89.3](0.89.2...0.89.3) (2024-05-02) ### Features * new feature to restart the API containers after the Kurtosis engine is started ([#2413](#2413)) ([494357f](494357f)) ### Bug Fixes * set service idempotency logic ([#2422](#2422)) ([cbd68bf](cbd68bf)) * update image UI arg parsing ([#2419](#2419)) ([cd3d928](cd3d928)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes how args are parsed and passing into script that updates images. Also fixes logic with how
initialSerializedParams
are set.Is this change user facing?
NO
References
#2406