feat: Start and Stop service Starlark instructions for K8S #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom the service to local connection map when the connections closes.
…s so we can easily re-create a pod to re-start the user service.
…rks for both backends.
laurentluce
commented
Jun 22, 2023
laurentluce
commented
Jun 22, 2023
...d_impls/kubernetes/kubernetes_kurtosis_backend/user_services_functions/stop_user_services.go
Show resolved
Hide resolved
Deploying with
|
| Latest commit: |
d9e01b9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://107217be.kurtosis-docs.pages.dev |
| Branch Preview URL: | https://laurent-start-stop-service-k.kurtosis-docs.pages.dev |
laurentluce
commented
Jun 22, 2023
...nal_testsuites/golang/testsuite/startosis_start_service_test/startosis_start_service_test.go
Show resolved
Hide resolved
gbouv
approved these changes
Jun 23, 2023
cli/cli/kurtosis_gateway/server/api_container_gateway/api_container_gateway_service_server.go
Outdated
Show resolved
Hide resolved
...d_impls/kubernetes/kubernetes_kurtosis_backend/user_services_functions/stop_user_services.go
Show resolved
Hide resolved
victorcolombo
pushed a commit
that referenced
this pull request
Jun 26, 2023
🤖 I have created a release *beep* *boop* --- ## [0.80.1](0.80.0...0.80.1) (2023-06-26) ### Features * Add Rust protobuf bindings ([#765](#765)) ([0e47003](0e47003)) * added wait to run_sh task. ([#750](#750)) ([8c2b697](8c2b697)) * Implemented rename enclave method in container engine lib ([#755](#755)) ([f1570f7](f1570f7)) * Persist enclave plan in the Starlark executor memory ([#757](#757)) ([2c3d74e](2c3d74e)) * Start and Stop service Starlark instructions for K8S ([#756](#756)) ([fb3e922](fb3e922)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Most of the work for the K8S backend was done as part of #694. In addition, the port forwarder reconnect feature reduced the amount of work we had to finish. Here are the changes made in this PR:
A service stopped here is a k8s service with no pod running. I think it is time to return the service status (registered, started, stopped) as part of the GetServices response so we can simplify the second item above. I will do that in a follow-up PR.
Is this change user facing?
YES
References (if applicable):
Closes #673
#694
#736