Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rollback during Node Table COPY #4467

Merged
merged 28 commits into from
Dec 2, 2024
Merged

Fix rollback during Node Table COPY #4467

merged 28 commits into from
Dec 2, 2024

Conversation

royi-luo
Copy link
Collaborator

@royi-luo royi-luo commented Nov 4, 2024 •
edited
Loading

Description

  • Implement in-memory hash index rollback for insertions
  • Inserts/deletes are now pushed to the undo buffer at the table level (instead of in ChunkedNodeGroup). This also prevents changes to temporary chunked node groups from being pushed to the undo buffer (which is a potential cause of use-after-frees).
  • New iterators are added that allow us to iterate over ChunkedNodeGroups in NodeGroups which we use to perform undo buffer commit/rollback
  • Empty node groups/chunked node groups are deleted during rollback
  • Fix in-memory hash index delete to properly find the last valid entry

Fixes #4338

Contributor agreement

@royi-luo royi-luo self-assigned this Nov 4, 2024
@royi-luo royi-luo changed the title Fix rollback during COPY Fix rollback during Node Table COPY Nov 4, 2024
@royi-luo royi-luo force-pushed the royi/rollback-hash-index branch from b0678c3 to aebf4b1 Compare November 5, 2024 19:57
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024

Benchmark Result

Master commit hash: fcd414d3f628e918d05a8cc9301e275b9ef1ecd8
Branch commit hash: 1cc2f8bd0e50e7a52c9aa58002dfd6138b9eee79

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 659.39 643.19 16.21 (2.52%)
aggregation q28 11858.18 11191.55 666.63 (5.96%)
filter q14 141.03 125.05 15.98 (12.78%)
filter q15 144.40 126.89 17.51 (13.80%)
filter q16 318.16 305.45 12.71 (4.16%)
filter q17 463.47 448.87 14.60 (3.25%)
filter q18 1924.98 1893.32 31.66 (1.67%)
filter zonemap-node 102.26 86.07 16.19 (18.81%)
filter zonemap-node-lhs-cast 102.76 86.48 16.28 (18.82%)
filter zonemap-rel 5604.48 5425.36 179.13 (3.30%)
fixed_size_expr_evaluator q07 557.43 546.49 10.94 (2.00%)
fixed_size_expr_evaluator q08 774.77 762.80 11.97 (1.57%)
fixed_size_expr_evaluator q09 771.22 758.55 12.67 (1.67%)
fixed_size_expr_evaluator q10 254.34 243.48 10.86 (4.46%)
fixed_size_expr_evaluator q11 250.44 238.28 12.15 (5.10%)
fixed_size_expr_evaluator q12 248.44 236.09 12.35 (5.23%)
fixed_size_expr_evaluator q13 1517.14 1472.49 44.66 (3.03%)
fixed_size_seq_scan q23 134.43 114.42 20.01 (17.49%)
join q29 599.56 593.21 6.35 (1.07%)
join q30 1362.26 1276.43 85.84 (6.72%)
join q31 3.99 4.27 -0.28 (-6.49%)
ldbc_snb_ic q35 479.34 411.84 67.50 (16.39%)
ldbc_snb_ic q36 34.78 32.28 2.50 (7.75%)
ldbc_snb_is q32 5.18 5.47 -0.30 (-5.40%)
ldbc_snb_is q33 11.13 10.72 0.41 (3.82%)
ldbc_snb_is q34 1.42 1.51 -0.09 (-6.04%)
multi-rel multi-rel-large-scan 1965.86 1897.43 68.43 (3.61%)
multi-rel multi-rel-lookup 27.14 31.77 -4.63 (-14.59%)
multi-rel multi-rel-small-scan 101.92 100.73 1.20 (1.19%)
order_by q25 148.62 131.70 16.92 (12.85%)
order_by q26 468.21 449.21 19.00 (4.23%)
order_by q27 1467.35 1448.49 18.86 (1.30%)
scan_after_filter q01 185.18 168.54 16.64 (9.87%)
scan_after_filter q02 172.16 157.59 14.57 (9.25%)
shortest_path_ldbc100 q37 84.76 85.59 -0.83 (-0.97%)
shortest_path_ldbc100 q38 443.08 457.46 -14.39 (-3.14%)
shortest_path_ldbc100 q39 62.84 64.49 -1.65 (-2.56%)
shortest_path_ldbc100 q40 555.03 537.63 17.40 (3.24%)
var_size_expr_evaluator q03 2083.47 2083.64 -0.18 (-0.01%)
var_size_expr_evaluator q04 2228.95 2206.28 22.67 (1.03%)
var_size_expr_evaluator q05 2625.51 2551.67 73.84 (2.89%)
var_size_expr_evaluator q06 1351.90 1324.31 27.59 (2.08%)
var_size_seq_scan q19 1491.74 1463.28 28.46 (1.95%)
var_size_seq_scan q20 2657.47 2506.22 151.25 (6.03%)
var_size_seq_scan q21 2327.49 2266.58 60.90 (2.69%)
var_size_seq_scan q22 132.01 128.74 3.27 (2.54%)

@codecov Codecov
Copy link

codecov bot commented Nov 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.14349% with 22 lines in your changes missing coverage. Please review.

Project coverage is 87.35%. Comparing base (f5224d7) to head (cec96e5).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/storage/store/node_table.cpp 95.37% 5 Missing ⚠️
src/storage/store/rel_table_data.cpp 93.18% 3 Missing ⚠️
test/copy/copy_test.cpp 95.89% 0 Missing and 3 partials ⚠️
src/include/common/mask.h 50.00% 2 Missing ⚠️
src/include/storage/store/column.h 0.00% 2 Missing ⚠️
src/include/storage/store/rel_table_data.h 50.00% 2 Missing ⚠️
src/storage/store/list_column.cpp 66.66% 2 Missing ⚠️
src/include/storage/store/node_table.h 50.00% 1 Missing ⚠️
src/storage/store/chunked_node_group.cpp 85.71% 1 Missing ⚠️
src/storage/store/rel_table.cpp 95.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4467      +/-   ##
==========================================
+ Coverage   87.26%   87.35%   +0.09%     
==========================================
  Files        1357     1358       +1     
  Lines       56772    57078     +306     
  Branches     7083     7109      +26     
==========================================
+ Hits        49541    49863     +322     
+ Misses       7069     7050      -19     
- Partials      162      165       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

Benchmark Result

Master commit hash: 100f975ae27f5a8cf19321ca2a325e8cc9d36b3d
Branch commit hash: 7b622b4f1d1fcf5f2635c7784bdf0817169b8c29

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 650.04 647.30 2.74 (0.42%)
aggregation q28 11036.54 11497.84 -461.31 (-4.01%)
filter q14 132.85 120.77 12.08 (10.01%)
filter q15 132.79 116.77 16.02 (13.72%)
filter q16 310.99 300.25 10.75 (3.58%)
filter q17 453.01 436.00 17.01 (3.90%)
filter q18 1913.96 1921.50 -7.55 (-0.39%)
filter zonemap-node 94.30 79.70 14.60 (18.32%)
filter zonemap-node-lhs-cast 94.62 78.05 16.56 (21.22%)
filter zonemap-rel 5575.85 5685.76 -109.91 (-1.93%)
fixed_size_expr_evaluator q07 551.29 543.96 7.33 (1.35%)
fixed_size_expr_evaluator q08 769.73 753.84 15.89 (2.11%)
fixed_size_expr_evaluator q09 770.73 754.19 16.54 (2.19%)
fixed_size_expr_evaluator q10 247.06 233.02 14.05 (6.03%)
fixed_size_expr_evaluator q11 241.51 224.31 17.20 (7.67%)
fixed_size_expr_evaluator q12 240.91 226.77 14.14 (6.23%)
fixed_size_expr_evaluator q13 1467.07 1481.59 -14.52 (-0.98%)
fixed_size_seq_scan q23 134.33 111.82 22.51 (20.13%)
join q29 643.49 623.76 19.74 (3.16%)
join q30 1315.17 1325.48 -10.32 (-0.78%)
join q31 3.26 3.79 -0.53 (-14.06%)
ldbc_snb_ic q35 480.40 489.83 -9.43 (-1.93%)
ldbc_snb_ic q36 34.42 33.68 0.74 (2.20%)
ldbc_snb_is q32 5.60 4.61 1.00 (21.62%)
ldbc_snb_is q33 9.15 11.65 -2.50 (-21.47%)
ldbc_snb_is q34 1.37 1.79 -0.42 (-23.42%)
multi-rel multi-rel-large-scan 2002.24 1598.57 403.67 (25.25%)
multi-rel multi-rel-lookup 10.23 20.59 -10.36 (-50.31%)
multi-rel multi-rel-small-scan 83.79 89.70 -5.91 (-6.59%)
order_by q25 139.97 122.48 17.49 (14.28%)
order_by q26 460.23 465.29 -5.06 (-1.09%)
order_by q27 1467.29 1446.49 20.79 (1.44%)
scan_after_filter q01 178.71 164.98 13.73 (8.32%)
scan_after_filter q02 164.56 149.95 14.61 (9.74%)
shortest_path_ldbc100 q37 85.22 71.86 13.37 (18.60%)
shortest_path_ldbc100 q38 451.98 483.02 -31.04 (-6.43%)
shortest_path_ldbc100 q39 60.91 62.26 -1.35 (-2.18%)
shortest_path_ldbc100 q40 541.59 552.49 -10.90 (-1.97%)
var_size_expr_evaluator q03 2082.60 2056.52 26.09 (1.27%)
var_size_expr_evaluator q04 2226.51 2268.26 -41.75 (-1.84%)
var_size_expr_evaluator q05 2612.36 2609.08 3.28 (0.13%)
var_size_expr_evaluator q06 1346.50 1331.47 15.03 (1.13%)
var_size_seq_scan q19 1459.91 1453.98 5.93 (0.41%)
var_size_seq_scan q20 2634.06 2742.71 -108.65 (-3.96%)
var_size_seq_scan q21 2282.96 2265.95 17.02 (0.75%)
var_size_seq_scan q22 130.57 125.65 4.92 (3.92%)

@royi-luo royi-luo force-pushed the royi/rollback-hash-index branch from 8fadc24 to 2f3f293 Compare November 13, 2024 23:07
@github-actions GitHub Actions
Copy link

Benchmark Result

Master commit hash: 1529bcc776731b879e5733929bb7e2902ea7c9e6
Branch commit hash: 483f3e639a0089c4011accdf0f133896d68627c5

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 643.13 650.17 -7.04 (-1.08%)
aggregation q28 11527.03 11927.07 -400.04 (-3.35%)
filter q14 127.23 134.76 -7.53 (-5.59%)
filter q15 127.52 135.20 -7.68 (-5.68%)
filter q16 309.07 313.26 -4.18 (-1.33%)
filter q17 444.39 453.34 -8.95 (-1.97%)
filter q18 1926.95 1905.07 21.88 (1.15%)
filter zonemap-node 87.01 96.13 -9.12 (-9.49%)
filter zonemap-node-lhs-cast 87.82 95.92 -8.10 (-8.45%)
filter zonemap-rel 5361.65 5361.65 -0.00 (-0.00%)
fixed_size_expr_evaluator q07 546.46 552.81 -6.35 (-1.15%)
fixed_size_expr_evaluator q08 762.87 766.47 -3.60 (-0.47%)
fixed_size_expr_evaluator q09 761.97 763.69 -1.72 (-0.23%)
fixed_size_expr_evaluator q10 243.31 245.87 -2.56 (-1.04%)
fixed_size_expr_evaluator q11 238.50 240.86 -2.36 (-0.98%)
fixed_size_expr_evaluator q12 237.78 240.13 -2.36 (-0.98%)
fixed_size_expr_evaluator q13 1479.69 1484.34 -4.65 (-0.31%)
fixed_size_seq_scan q23 117.21 125.17 -7.96 (-6.36%)
join q29 596.21 596.24 -0.03 (-0.00%)
join q30 1465.08 1323.11 141.97 (10.73%)
join q31 3.96 3.98 -0.02 (-0.62%)
ldbc_snb_ic q35 392.27 418.56 -26.30 (-6.28%)
ldbc_snb_ic q36 144.52 127.20 17.32 (13.62%)
ldbc_snb_is q32 4.06 5.25 -1.19 (-22.69%)
ldbc_snb_is q33 11.92 10.93 0.99 (9.06%)
ldbc_snb_is q34 1.46 1.66 -0.20 (-11.80%)
multi-rel multi-rel-large-scan 1597.55 1583.24 14.31 (0.90%)
multi-rel multi-rel-lookup 28.83 6.22 22.61 (363.43%)
multi-rel multi-rel-small-scan 93.36 91.39 1.97 (2.16%)
order_by q25 137.14 137.86 -0.72 (-0.52%)
order_by q26 450.44 461.76 -11.32 (-2.45%)
order_by q27 1450.57 1463.51 -12.94 (-0.88%)
scan_after_filter q01 172.63 178.87 -6.24 (-3.49%)
scan_after_filter q02 158.04 165.70 -7.67 (-4.63%)
shortest_path_ldbc100 q37 92.27 94.88 -2.61 (-2.75%)
shortest_path_ldbc100 q38 461.17 515.74 -54.57 (-10.58%)
shortest_path_ldbc100 q39 63.53 60.50 3.03 (5.01%)
shortest_path_ldbc100 q40 543.89 544.55 -0.67 (-0.12%)
var_size_expr_evaluator q03 2043.16 2075.14 -31.98 (-1.54%)
var_size_expr_evaluator q04 2238.67 2211.46 27.20 (1.23%)
var_size_expr_evaluator q05 2592.64 2659.08 -66.44 (-2.50%)
var_size_expr_evaluator q06 1317.78 1343.04 -25.26 (-1.88%)
var_size_seq_scan q19 1444.33 1469.61 -25.28 (-1.72%)
var_size_seq_scan q20 2383.35 2365.42 17.93 (0.76%)
var_size_seq_scan q21 2256.55 2275.64 -19.10 (-0.84%)
var_size_seq_scan q22 127.64 129.08 -1.44 (-1.12%)

@github-actions GitHub Actions
Copy link

Benchmark Result

Master commit hash: 8b08ed3fae85391a393589c4339a3086126df2ab
Branch commit hash: de726794ee909d1446666e326d2f428f15b4b3b1

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 648.32 652.97 -4.65 (-0.71%)
aggregation q28 11697.30 11274.37 422.93 (3.75%)
filter q14 133.03 132.59 0.45 (0.34%)
filter q15 134.16 134.37 -0.22 (-0.16%)
filter q16 312.86 314.55 -1.70 (-0.54%)
filter q17 455.00 453.59 1.41 (0.31%)
filter q18 1931.29 1899.98 31.31 (1.65%)
filter zonemap-node 94.33 95.37 -1.03 (-1.08%)
filter zonemap-node-lhs-cast 94.84 95.09 -0.25 (-0.26%)
filter zonemap-rel 5337.15 5316.22 20.93 (0.39%)
fixed_size_expr_evaluator q07 554.42 551.58 2.84 (0.52%)
fixed_size_expr_evaluator q08 770.03 765.09 4.94 (0.65%)
fixed_size_expr_evaluator q09 767.47 765.73 1.73 (0.23%)
fixed_size_expr_evaluator q10 249.63 245.83 3.79 (1.54%)
fixed_size_expr_evaluator q11 244.33 241.09 3.24 (1.34%)
fixed_size_expr_evaluator q12 242.85 241.37 1.48 (0.61%)
fixed_size_expr_evaluator q13 1482.40 1486.59 -4.18 (-0.28%)
fixed_size_seq_scan q23 125.85 126.65 -0.80 (-0.63%)
join q29 608.88 639.83 -30.94 (-4.84%)
join q30 1350.50 1382.05 -31.55 (-2.28%)
join q31 2.82 3.36 -0.54 (-15.95%)
ldbc_snb_ic q35 470.71 421.63 49.07 (11.64%)
ldbc_snb_ic q36 117.60 146.48 -28.88 (-19.72%)
ldbc_snb_is q32 4.84 5.10 -0.26 (-5.16%)
ldbc_snb_is q33 10.20 9.73 0.47 (4.82%)
ldbc_snb_is q34 1.30 1.70 -0.39 (-23.23%)
multi-rel multi-rel-large-scan 1587.69 1932.01 -344.31 (-17.82%)
multi-rel multi-rel-lookup 23.35 10.41 12.94 (124.36%)
multi-rel multi-rel-small-scan 94.80 79.39 15.42 (19.42%)
order_by q25 143.48 139.71 3.77 (2.70%)
order_by q26 472.70 461.47 11.23 (2.43%)
order_by q27 1469.93 1462.76 7.18 (0.49%)
scan_after_filter q01 178.48 177.27 1.21 (0.68%)
scan_after_filter q02 166.04 162.94 3.10 (1.90%)
shortest_path_ldbc100 q37 99.33 83.53 15.80 (18.92%)
shortest_path_ldbc100 q38 465.43 469.02 -3.60 (-0.77%)
shortest_path_ldbc100 q39 66.00 58.23 7.77 (13.34%)
shortest_path_ldbc100 q40 558.85 534.07 24.78 (4.64%)
var_size_expr_evaluator q03 2058.77 2063.91 -5.13 (-0.25%)
var_size_expr_evaluator q04 2249.57 2216.74 32.83 (1.48%)
var_size_expr_evaluator q05 2616.57 2668.28 -51.71 (-1.94%)
var_size_expr_evaluator q06 1346.13 1341.12 5.00 (0.37%)
var_size_seq_scan q19 1464.71 1463.03 1.69 (0.12%)
var_size_seq_scan q20 2377.17 2370.35 6.82 (0.29%)
var_size_seq_scan q21 2331.53 2273.46 58.07 (2.55%)
var_size_seq_scan q22 142.54 130.25 12.29 (9.44%)

@royi-luo royi-luo force-pushed the royi/rollback-hash-index branch from 5c01907 to 4d09b6d Compare November 15, 2024 20:25
@github-actions GitHub Actions
Copy link

Benchmark Result

Master commit hash: 6157e576c65834cdd41da3eddec0dbc74039b03f
Branch commit hash: 1afd58706c06211ff664b3ac86a4192ac7e6bbed

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 642.46 642.76 -0.31 (-0.05%)
aggregation q28 12506.77 11289.89 1216.89 (10.78%)
filter q14 126.93 124.77 2.16 (1.73%)
filter q15 125.42 128.93 -3.50 (-2.72%)
filter q16 298.73 299.43 -0.70 (-0.23%)
filter q17 447.07 447.73 -0.67 (-0.15%)
filter q18 1930.12 1914.08 16.04 (0.84%)
filter zonemap-node 86.41 87.11 -0.70 (-0.80%)
filter zonemap-node-lhs-cast 88.49 87.83 0.67 (0.76%)
filter zonemap-rel 5333.07 5324.72 8.35 (0.16%)
fixed_size_expr_evaluator q07 541.97 542.71 -0.73 (-0.13%)
fixed_size_expr_evaluator q08 759.28 757.58 1.71 (0.23%)
fixed_size_expr_evaluator q09 757.65 756.99 0.66 (0.09%)
fixed_size_expr_evaluator q10 237.26 238.31 -1.05 (-0.44%)
fixed_size_expr_evaluator q11 232.84 232.61 0.23 (0.10%)
fixed_size_expr_evaluator q12 232.04 232.68 -0.65 (-0.28%)
fixed_size_expr_evaluator q13 1460.56 1463.78 -3.22 (-0.22%)
fixed_size_seq_scan q23 118.37 116.74 1.63 (1.40%)
join q29 612.37 623.58 -11.22 (-1.80%)
join q30 1355.02 1410.01 -54.99 (-3.90%)
join q31 4.89 3.88 1.01 (25.93%)
ldbc_snb_ic q35 423.39 528.52 -105.13 (-19.89%)
ldbc_snb_ic q36 138.55 122.22 16.33 (13.36%)
ldbc_snb_is q32 7.57 6.78 0.79 (11.66%)
ldbc_snb_is q33 11.20 10.86 0.34 (3.13%)
ldbc_snb_is q34 1.66 1.17 0.49 (41.91%)
multi-rel multi-rel-large-scan 1616.95 1817.59 -200.64 (-11.04%)
multi-rel multi-rel-lookup 21.17 31.42 -10.25 (-32.61%)
multi-rel multi-rel-small-scan 76.39 108.14 -31.75 (-29.36%)
order_by q25 129.42 135.45 -6.04 (-4.46%)
order_by q26 455.14 456.97 -1.83 (-0.40%)
order_by q27 1439.97 1442.78 -2.80 (-0.19%)
scan_after_filter q01 169.86 168.64 1.22 (0.72%)
scan_after_filter q02 161.16 154.36 6.80 (4.40%)
shortest_path_ldbc100 q37 86.73 88.50 -1.76 (-1.99%)
shortest_path_ldbc100 q38 494.11 467.31 26.80 (5.74%)
shortest_path_ldbc100 q39 61.12 64.54 -3.42 (-5.30%)
shortest_path_ldbc100 q40 552.88 540.00 12.88 (2.38%)
var_size_expr_evaluator q03 2033.17 2036.87 -3.70 (-0.18%)
var_size_expr_evaluator q04 2207.94 2227.29 -19.35 (-0.87%)
var_size_expr_evaluator q05 2520.90 2537.25 -16.35 (-0.64%)
var_size_expr_evaluator q06 1323.97 1328.71 -4.74 (-0.36%)
var_size_seq_scan q19 1448.67 1442.22 6.45 (0.45%)
var_size_seq_scan q20 2395.96 2399.28 -3.32 (-0.14%)
var_size_seq_scan q21 2267.05 2267.35 -0.30 (-0.01%)
var_size_seq_scan q22 125.85 127.17 -1.31 (-1.03%)

@github-actions GitHub Actions
Copy link

Benchmark Result

Master commit hash: 6157e576c65834cdd41da3eddec0dbc74039b03f
Branch commit hash: 0964e5a96f7a2319dc2c3bfd86df8f1c77630648

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 642.35 642.76 -0.41 (-0.06%)
aggregation q28 11216.56 11289.89 -73.32 (-0.65%)
filter q14 126.20 124.77 1.43 (1.15%)
filter q15 125.92 128.93 -3.01 (-2.33%)
filter q16 304.17 299.43 4.74 (1.58%)
filter q17 445.75 447.73 -1.99 (-0.44%)
filter q18 1899.83 1914.08 -14.24 (-0.74%)
filter zonemap-node 86.18 87.11 -0.93 (-1.07%)
filter zonemap-node-lhs-cast 88.24 87.83 0.41 (0.47%)
filter zonemap-rel 5313.20 5324.72 -11.52 (-0.22%)
fixed_size_expr_evaluator q07 542.97 542.71 0.26 (0.05%)
fixed_size_expr_evaluator q08 759.69 757.58 2.12 (0.28%)
fixed_size_expr_evaluator q09 758.89 756.99 1.91 (0.25%)
fixed_size_expr_evaluator q10 237.98 238.31 -0.33 (-0.14%)
fixed_size_expr_evaluator q11 233.53 232.61 0.91 (0.39%)
fixed_size_expr_evaluator q12 231.78 232.68 -0.90 (-0.39%)
fixed_size_expr_evaluator q13 1477.53 1463.78 13.75 (0.94%)
fixed_size_seq_scan q23 115.19 116.74 -1.55 (-1.33%)
join q29 628.34 623.58 4.75 (0.76%)
join q30 1334.38 1410.01 -75.64 (-5.36%)
join q31 2.81 3.88 -1.07 (-27.61%)
ldbc_snb_ic q35 420.06 528.52 -108.46 (-20.52%)
ldbc_snb_ic q36 136.46 122.22 14.24 (11.65%)
ldbc_snb_is q32 6.19 6.78 -0.59 (-8.73%)
ldbc_snb_is q33 10.93 10.86 0.07 (0.65%)
ldbc_snb_is q34 1.80 1.17 0.63 (53.53%)
multi-rel multi-rel-large-scan 1881.76 1817.59 64.16 (3.53%)
multi-rel multi-rel-lookup 29.19 31.42 -2.22 (-7.08%)
multi-rel multi-rel-small-scan 92.00 108.14 -16.15 (-14.93%)
order_by q25 132.82 135.45 -2.63 (-1.94%)
order_by q26 464.10 456.97 7.13 (1.56%)
order_by q27 1443.34 1442.78 0.57 (0.04%)
scan_after_filter q01 168.02 168.64 -0.62 (-0.37%)
scan_after_filter q02 158.65 154.36 4.29 (2.78%)
shortest_path_ldbc100 q37 87.55 88.50 -0.95 (-1.07%)
shortest_path_ldbc100 q38 467.11 467.31 -0.20 (-0.04%)
shortest_path_ldbc100 q39 61.00 64.54 -3.54 (-5.48%)
shortest_path_ldbc100 q40 552.02 540.00 12.02 (2.23%)
var_size_expr_evaluator q03 2037.66 2036.87 0.79 (0.04%)
var_size_expr_evaluator q04 2215.94 2227.29 -11.35 (-0.51%)
var_size_expr_evaluator q05 2604.42 2537.25 67.16 (2.65%)
var_size_expr_evaluator q06 1317.71 1328.71 -11.00 (-0.83%)
var_size_seq_scan q19 1450.82 1442.22 8.60 (0.60%)
var_size_seq_scan q20 2394.94 2399.28 -4.34 (-0.18%)
var_size_seq_scan q21 2258.53 2267.35 -8.83 (-0.39%)
var_size_seq_scan q22 128.19 127.17 1.02 (0.80%)

@royi-luo royi-luo force-pushed the royi/rollback-hash-index branch from 966535c to 40d77f2 Compare November 18, 2024 15:53
@github-actions GitHub Actions
Copy link

Benchmark Result

Master commit hash: 2591604a296914fbf6be4e7fc8cb57649b9fb712
Branch commit hash: cea2417d79eea085e32db87ca024d83cd85a7b5a

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 636.49 634.77 1.72 (0.27%)
aggregation q28 11118.24 12202.42 -1084.18 (-8.88%)
filter q14 123.87 119.80 4.07 (3.40%)
filter q15 121.77 117.93 3.84 (3.26%)
filter q16 294.08 293.71 0.38 (0.13%)
filter q17 436.17 439.04 -2.87 (-0.65%)
filter q18 1942.67 1942.23 0.44 (0.02%)
filter zonemap-node 78.23 78.17 0.06 (0.08%)
filter zonemap-node-lhs-cast 79.51 79.68 -0.17 (-0.22%)
filter zonemap-rel 5462.26 5560.61 -98.35 (-1.77%)
fixed_size_expr_evaluator q07 536.75 533.45 3.29 (0.62%)
fixed_size_expr_evaluator q08 760.10 753.44 6.66 (0.88%)
fixed_size_expr_evaluator q09 751.18 753.43 -2.26 (-0.30%)
fixed_size_expr_evaluator q10 230.26 229.63 0.62 (0.27%)
fixed_size_expr_evaluator q11 224.74 225.30 -0.56 (-0.25%)
fixed_size_expr_evaluator q12 226.13 225.24 0.89 (0.39%)
fixed_size_expr_evaluator q13 1457.94 1459.85 -1.91 (-0.13%)
fixed_size_seq_scan q23 108.04 114.29 -6.25 (-5.47%)
join q29 648.21 600.09 48.13 (8.02%)
join q30 1419.09 1382.97 36.12 (2.61%)
join q31 7.85 4.12 3.72 (90.35%)
ldbc_snb_ic q35 424.11 420.82 3.29 (0.78%)
ldbc_snb_ic q36 138.64 126.47 12.16 (9.62%)
ldbc_snb_is q32 6.70 4.62 2.08 (44.89%)
ldbc_snb_is q33 13.13 15.66 -2.53 (-16.14%)
ldbc_snb_is q34 1.48 1.25 0.22 (17.94%)
multi-rel multi-rel-large-scan 1566.11 1827.59 -261.48 (-14.31%)
multi-rel multi-rel-lookup 35.38 33.56 1.82 (5.44%)
multi-rel multi-rel-small-scan 86.16 86.28 -0.12 (-0.14%)
order_by q25 120.22 123.64 -3.42 (-2.77%)
order_by q26 441.27 442.99 -1.72 (-0.39%)
order_by q27 1396.79 1406.73 -9.93 (-0.71%)
scan_after_filter q01 163.60 164.36 -0.76 (-0.46%)
scan_after_filter q02 148.06 152.06 -4.00 (-2.63%)
shortest_path_ldbc100 q37 86.28 80.49 5.79 (7.19%)
shortest_path_ldbc100 q38 474.86 464.08 10.78 (2.32%)
shortest_path_ldbc100 q39 59.03 56.76 2.27 (3.99%)
shortest_path_ldbc100 q40 569.87 515.51 54.36 (10.54%)
var_size_expr_evaluator q03 2075.06 2052.36 22.71 (1.11%)
var_size_expr_evaluator q04 2270.59 2228.79 41.79 (1.88%)
var_size_expr_evaluator q05 2681.65 2528.80 152.85 (6.04%)
var_size_expr_evaluator q06 1317.97 1354.29 -36.33 (-2.68%)
var_size_seq_scan q19 1461.97 1465.48 -3.52 (-0.24%)
var_size_seq_scan q20 2498.10 2594.17 -96.07 (-3.70%)
var_size_seq_scan q21 2279.94 2287.94 -8.00 (-0.35%)
var_size_seq_scan q22 126.22 126.78 -0.57 (-0.45%)

@royi-luo royi-luo force-pushed the royi/rollback-hash-index branch 5 times, most recently from 98076f8 to 3446b23 Compare November 18, 2024 23:19
@github-actions GitHub Actions
Copy link

Benchmark Result

Master commit hash: 6f1bf5b60107419eb2f4d947ca0fd8ed477f72b0
Branch commit hash: c5a60d7b20884657985e2904dc7d0471274e71f8

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 642.81 642.95 -0.14 (-0.02%)
aggregation q28 11743.77 11469.90 273.87 (2.39%)
filter q14 125.51 126.43 -0.92 (-0.72%)
filter q15 127.16 123.37 3.78 (3.07%)
filter q16 305.14 303.19 1.95 (0.64%)
filter q17 444.94 444.82 0.12 (0.03%)
filter q18 1921.45 1946.70 -25.26 (-1.30%)
filter zonemap-node 86.20 86.57 -0.37 (-0.43%)
filter zonemap-node-lhs-cast 87.54 86.53 1.01 (1.17%)
filter zonemap-rel 5318.54 5743.59 -425.04 (-7.40%)
fixed_size_expr_evaluator q07 543.48 544.45 -0.98 (-0.18%)
fixed_size_expr_evaluator q08 761.06 778.80 -17.73 (-2.28%)
fixed_size_expr_evaluator q09 756.05 774.16 -18.11 (-2.34%)
fixed_size_expr_evaluator q10 237.75 238.02 -0.27 (-0.11%)
fixed_size_expr_evaluator q11 232.82 237.01 -4.19 (-1.77%)
fixed_size_expr_evaluator q12 233.62 236.82 -3.19 (-1.35%)
fixed_size_expr_evaluator q13 1467.51 1503.38 -35.87 (-2.39%)
fixed_size_seq_scan q23 115.51 119.91 -4.41 (-3.67%)
join q29 636.16 662.44 -26.28 (-3.97%)
join q30 1448.16 1289.55 158.62 (12.30%)
join q31 6.92 7.01 -0.09 (-1.23%)
ldbc_snb_ic q35 417.32 406.73 10.59 (2.60%)
ldbc_snb_ic q36 132.22 126.12 6.10 (4.84%)
ldbc_snb_is q32 4.37 5.16 -0.79 (-15.40%)
ldbc_snb_is q33 13.98 15.12 -1.14 (-7.53%)
ldbc_snb_is q34 1.35 1.61 -0.26 (-16.03%)
multi-rel multi-rel-large-scan 2046.65 1612.54 434.10 (26.92%)
multi-rel multi-rel-lookup 7.61 21.53 -13.91 (-64.63%)
multi-rel multi-rel-small-scan 88.16 99.58 -11.42 (-11.47%)
order_by q25 129.63 131.52 -1.89 (-1.44%)
order_by q26 466.12 460.60 5.52 (1.20%)
order_by q27 1393.98 1435.41 -41.43 (-2.89%)
scan_after_filter q01 172.27 174.04 -1.77 (-1.02%)
scan_after_filter q02 157.42 157.98 -0.57 (-0.36%)
shortest_path_ldbc100 q37 95.11 84.91 10.20 (12.02%)
shortest_path_ldbc100 q38 483.96 418.99 64.97 (15.51%)
shortest_path_ldbc100 q39 66.69 63.00 3.69 (5.86%)
shortest_path_ldbc100 q40 588.70 514.13 74.57 (14.50%)
var_size_expr_evaluator q03 2080.39 2102.75 -22.35 (-1.06%)
var_size_expr_evaluator q04 2232.27 2268.57 -36.30 (-1.60%)
var_size_expr_evaluator q05 2537.62 2699.13 -161.50 (-5.98%)
var_size_expr_evaluator q06 1339.69 1345.60 -5.91 (-0.44%)
var_size_seq_scan q19 1463.63 1479.78 -16.15 (-1.09%)
var_size_seq_scan q20 2537.83 2767.61 -229.77 (-8.30%)
var_size_seq_scan q21 2282.06 2317.91 -35.85 (-1.55%)
var_size_seq_scan q22 127.37 130.39 -3.02 (-2.32%)

@github-actions GitHub Actions
Copy link

Benchmark Result

Master commit hash: de8edf92ecff383c8b889bb671456134cd5c18f0
Branch commit hash: 4320fad9a19b859184f25b03b7aea524c7abca2a

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 636.66 643.10 -6.44 (-1.00%)
aggregation q28 11678.76 12256.73 -577.97 (-4.72%)
filter q14 119.23 127.65 -8.42 (-6.59%)
filter q15 118.31 124.99 -6.68 (-5.35%)
filter q16 299.02 304.07 -5.05 (-1.66%)
filter q17 439.13 444.69 -5.56 (-1.25%)
filter q18 1888.30 1962.72 -74.42 (-3.79%)
filter zonemap-node 77.98 86.16 -8.18 (-9.49%)
filter zonemap-node-lhs-cast 78.05 86.32 -8.28 (-9.59%)
filter zonemap-rel 5356.80 5517.32 -160.53 (-2.91%)
fixed_size_expr_evaluator q07 533.66 542.87 -9.21 (-1.70%)
fixed_size_expr_evaluator q08 752.51 759.18 -6.67 (-0.88%)
fixed_size_expr_evaluator q09 750.98 757.51 -6.53 (-0.86%)
fixed_size_expr_evaluator q10 231.09 239.94 -8.84 (-3.69%)
fixed_size_expr_evaluator q11 225.01 232.28 -7.27 (-3.13%)
fixed_size_expr_evaluator q12 224.32 231.34 -7.02 (-3.03%)
fixed_size_expr_evaluator q13 1463.00 1464.37 -1.37 (-0.09%)
fixed_size_seq_scan q23 109.83 113.90 -4.07 (-3.57%)
join q29 658.78 653.65 5.13 (0.79%)
join q30 1366.62 1463.50 -96.88 (-6.62%)
join q31 4.98 4.10 0.89 (21.65%)
ldbc_snb_ic q35 432.11 419.08 13.03 (3.11%)
ldbc_snb_ic q36 132.04 123.01 9.03 (7.34%)
ldbc_snb_is q32 5.80 4.50 1.30 (28.89%)
ldbc_snb_is q33 11.30 12.40 -1.10 (-8.85%)
ldbc_snb_is q34 1.69 1.43 0.26 (18.22%)
multi-rel multi-rel-large-scan 1631.37 1931.29 -299.92 (-15.53%)
multi-rel multi-rel-lookup 6.68 6.36 0.32 (5.06%)
multi-rel multi-rel-small-scan 86.31 95.26 -8.95 (-9.39%)
order_by q25 128.04 129.91 -1.87 (-1.44%)
order_by q26 445.40 462.12 -16.73 (-3.62%)
order_by q27 1373.92 1414.64 -40.72 (-2.88%)
scan_after_filter q01 161.59 170.71 -9.11 (-5.34%)
scan_after_filter q02 149.34 156.23 -6.90 (-4.41%)
shortest_path_ldbc100 q37 93.68 80.14 13.54 (16.90%)
shortest_path_ldbc100 q38 457.26 444.31 12.95 (2.91%)
shortest_path_ldbc100 q39 62.67 60.48 2.19 (3.62%)
shortest_path_ldbc100 q40 545.41 536.57 8.83 (1.65%)
var_size_expr_evaluator q03 2033.19 2079.70 -46.52 (-2.24%)
var_size_expr_evaluator q04 2170.36 2237.54 -67.18 (-3.00%)
var_size_expr_evaluator q05 2597.37 2687.41 -90.04 (-3.35%)
var_size_expr_evaluator q06 1308.86 1343.17 -34.31 (-2.55%)
var_size_seq_scan q19 1440.73 1476.17 -35.44 (-2.40%)
var_size_seq_scan q20 2493.50 2578.96 -85.46 (-3.31%)
var_size_seq_scan q21 2268.40 2301.50 -33.10 (-1.44%)
var_size_seq_scan q22 125.19 133.03 -7.84 (-5.89%)

@royi-luo royi-luo force-pushed the royi/rollback-hash-index branch from 56b31fc to a8ac1d2 Compare November 20, 2024 15:49
@github-actions GitHub Actions
Copy link

Benchmark Result

Master commit hash: 71f31389315b87c2c8cf2229727c59f20cac20b5
Branch commit hash: 3b27e8028d93d866f04cd15ae24168985ce8ad88

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 642.82 640.85 1.96 (0.31%)
aggregation q28 12182.49 11570.46 612.04 (5.29%)
filter q14 125.50 124.63 0.87 (0.70%)
filter q15 125.90 130.56 -4.66 (-3.57%)
filter q16 307.60 307.18 0.42 (0.14%)
filter q17 447.18 452.14 -4.96 (-1.10%)
filter q18 1938.14 1898.32 39.82 (2.10%)
filter zonemap-node 86.54 86.60 -0.06 (-0.07%)
filter zonemap-node-lhs-cast 86.94 88.91 -1.97 (-2.21%)
filter zonemap-rel 5407.52 5520.38 -112.86 (-2.04%)
fixed_size_expr_evaluator q07 542.70 541.80 0.90 (0.17%)
fixed_size_expr_evaluator q08 759.44 760.14 -0.70 (-0.09%)
fixed_size_expr_evaluator q09 755.85 760.29 -4.45 (-0.58%)
fixed_size_expr_evaluator q10 239.08 238.62 0.46 (0.19%)
fixed_size_expr_evaluator q11 232.96 232.45 0.51 (0.22%)
fixed_size_expr_evaluator q12 234.73 231.73 3.00 (1.29%)
fixed_size_expr_evaluator q13 1481.28 1471.10 10.18 (0.69%)
fixed_size_seq_scan q23 116.79 119.27 -2.47 (-2.07%)
join q29 634.66 627.74 6.91 (1.10%)
join q30 1335.26 1338.87 -3.61 (-0.27%)
join q31 6.47 5.81 0.66 (11.32%)
ldbc_snb_ic q35 427.41 446.22 -18.81 (-4.21%)
ldbc_snb_ic q36 132.24 118.61 13.63 (11.49%)
ldbc_snb_is q32 3.52 2.04 1.47 (71.95%)
ldbc_snb_is q33 13.58 13.41 0.17 (1.26%)
ldbc_snb_is q34 1.28 1.55 -0.27 (-17.48%)
multi-rel multi-rel-large-scan 1830.22 1824.78 5.44 (0.30%)
multi-rel multi-rel-lookup 6.30 31.54 -25.24 (-80.01%)
multi-rel multi-rel-small-scan 69.67 85.89 -16.22 (-18.88%)
order_by q25 129.19 127.15 2.04 (1.60%)
order_by q26 445.16 449.53 -4.37 (-0.97%)
order_by q27 1415.39 1394.39 21.00 (1.51%)
scan_after_filter q01 170.35 170.53 -0.17 (-0.10%)
scan_after_filter q02 153.73 160.25 -6.53 (-4.07%)
shortest_path_ldbc100 q37 88.13 91.20 -3.07 (-3.36%)
shortest_path_ldbc100 q38 455.87 491.79 -35.92 (-7.30%)
shortest_path_ldbc100 q39 61.46 59.86 1.60 (2.68%)
shortest_path_ldbc100 q40 524.57 546.92 -22.35 (-4.09%)
var_size_expr_evaluator q03 2078.55 2056.88 21.66 (1.05%)
var_size_expr_evaluator q04 2292.98 2217.98 75.01 (3.38%)
var_size_expr_evaluator q05 2644.43 2583.63 60.81 (2.35%)
var_size_expr_evaluator q06 1344.78 1334.42 10.36 (0.78%)
var_size_seq_scan q19 1480.86 1456.96 23.90 (1.64%)
var_size_seq_scan q20 2467.98 2566.20 -98.22 (-3.83%)
var_size_seq_scan q21 2295.44 2283.56 11.88 (0.52%)
var_size_seq_scan q22 131.23 127.12 4.11 (3.24%)

@github-actions GitHub Actions
Copy link

Benchmark Result

Master commit hash: 71f31389315b87c2c8cf2229727c59f20cac20b5
Branch commit hash: 45685f62695dd7c6ca7672c4119537b4ec776478

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 634.16 640.85 -6.69 (-1.04%)
aggregation q28 11944.29 11570.46 373.83 (3.23%)
filter q14 118.39 124.63 -6.24 (-5.00%)
filter q15 116.27 130.56 -14.29 (-10.95%)
filter q16 296.62 307.18 -10.56 (-3.44%)
filter q17 436.41 452.14 -15.73 (-3.48%)
filter q18 1949.44 1898.32 51.12 (2.69%)
filter zonemap-node 78.12 86.60 -8.48 (-9.79%)
filter zonemap-node-lhs-cast 78.14 88.91 -10.76 (-12.11%)
filter zonemap-rel 5345.35 5520.38 -175.04 (-3.17%)
fixed_size_expr_evaluator q07 533.89 541.80 -7.91 (-1.46%)
fixed_size_expr_evaluator q08 748.12 760.14 -12.02 (-1.58%)
fixed_size_expr_evaluator q09 752.53 760.29 -7.76 (-1.02%)
fixed_size_expr_evaluator q10 230.43 238.62 -8.19 (-3.43%)
fixed_size_expr_evaluator q11 224.03 232.45 -8.43 (-3.63%)
fixed_size_expr_evaluator q12 223.53 231.73 -8.20 (-3.54%)
fixed_size_expr_evaluator q13 1469.50 1471.10 -1.60 (-0.11%)
fixed_size_seq_scan q23 108.05 119.27 -11.22 (-9.40%)
join q29 589.63 627.74 -38.11 (-6.07%)
join q30 1370.29 1338.87 31.42 (2.35%)
join q31 6.18 5.81 0.36 (6.28%)
ldbc_snb_ic q35 470.19 446.22 23.97 (5.37%)
ldbc_snb_ic q36 128.46 118.61 9.85 (8.30%)
ldbc_snb_is q32 4.89 2.04 2.85 (139.22%)
ldbc_snb_is q33 11.73 13.41 -1.68 (-12.54%)
ldbc_snb_is q34 1.30 1.55 -0.25 (-15.99%)
multi-rel multi-rel-large-scan 1825.93 1824.78 1.15 (0.06%)
multi-rel multi-rel-lookup 11.17 31.54 -20.37 (-64.59%)
multi-rel multi-rel-small-scan 99.55 85.89 13.66 (15.90%)
order_by q25 122.81 127.15 -4.34 (-3.41%)
order_by q26 435.84 449.53 -13.69 (-3.04%)
order_by q27 1404.67 1394.39 10.28 (0.74%)
scan_after_filter q01 159.96 170.53 -10.57 (-6.20%)
scan_after_filter q02 149.12 160.25 -11.14 (-6.95%)
shortest_path_ldbc100 q37 95.93 91.20 4.73 (5.19%)
shortest_path_ldbc100 q38 474.18 491.79 -17.61 (-3.58%)
shortest_path_ldbc100 q39 58.90 59.86 -0.96 (-1.60%)
shortest_path_ldbc100 q40 536.18 546.92 -10.74 (-1.96%)
var_size_expr_evaluator q03 2064.10 2056.88 7.22 (0.35%)
var_size_expr_evaluator q04 2255.04 2217.98 37.07 (1.67%)
var_size_expr_evaluator q05 2636.49 2583.63 52.86 (2.05%)
var_size_expr_evaluator q06 1331.95 1334.42 -2.47 (-0.19%)
var_size_seq_scan q19 1477.18 1456.96 20.23 (1.39%)
var_size_seq_scan q20 2428.02 2566.20 -138.18 (-5.38%)
var_size_seq_scan q21 2286.38 2283.56 2.83 (0.12%)
var_size_seq_scan q22 127.58 127.12 0.47 (0.37%)

@github-actions GitHub Actions
Copy link

Benchmark Result

Master commit hash: 71f31389315b87c2c8cf2229727c59f20cac20b5
Branch commit hash: a8297d15cb8338bb1525643e09b09227e2752385

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 631.64 640.85 -9.21 (-1.44%)
aggregation q28 11325.15 11570.46 -245.31 (-2.12%)
filter q14 117.55 124.63 -7.08 (-5.68%)
filter q15 123.09 130.56 -7.47 (-5.72%)
filter q16 297.74 307.18 -9.44 (-3.07%)
filter q17 436.47 452.14 -15.67 (-3.47%)
filter q18 1930.15 1898.32 31.83 (1.68%)
filter zonemap-node 78.28 86.60 -8.32 (-9.60%)
filter zonemap-node-lhs-cast 79.19 88.91 -9.71 (-10.93%)
filter zonemap-rel 5396.78 5520.38 -123.60 (-2.24%)
fixed_size_expr_evaluator q07 533.75 541.80 -8.05 (-1.49%)
fixed_size_expr_evaluator q08 749.84 760.14 -10.30 (-1.36%)
fixed_size_expr_evaluator q09 750.96 760.29 -9.33 (-1.23%)
fixed_size_expr_evaluator q10 233.62 238.62 -5.00 (-2.10%)
fixed_size_expr_evaluator q11 225.82 232.45 -6.63 (-2.85%)
fixed_size_expr_evaluator q12 223.88 231.73 -7.85 (-3.39%)
fixed_size_expr_evaluator q13 1472.06 1471.10 0.96 (0.07%)
fixed_size_seq_scan q23 115.95 119.27 -3.32 (-2.78%)
join q29 639.79 627.74 12.05 (1.92%)
join q30 1444.97 1338.87 106.10 (7.92%)
join q31 8.23 5.81 2.42 (41.58%)
ldbc_snb_ic q35 417.11 446.22 -29.11 (-6.52%)
ldbc_snb_ic q36 114.92 118.61 -3.69 (-3.11%)
ldbc_snb_is q32 3.67 2.04 1.63 (79.69%)
ldbc_snb_is q33 12.06 13.41 -1.35 (-10.04%)
ldbc_snb_is q34 1.59 1.55 0.04 (2.76%)
multi-rel multi-rel-large-scan 1642.06 1824.78 -182.72 (-10.01%)
multi-rel multi-rel-lookup 19.61 31.54 -11.93 (-37.81%)
multi-rel multi-rel-small-scan 75.12 85.89 -10.77 (-12.54%)
order_by q25 127.15 127.15 0.00 (0.00%)
order_by q26 438.08 449.53 -11.45 (-2.55%)
order_by q27 1408.73 1394.39 14.34 (1.03%)
scan_after_filter q01 161.99 170.53 -8.53 (-5.00%)
scan_after_filter q02 144.86 160.25 -15.39 (-9.60%)
shortest_path_ldbc100 q37 98.53 91.20 7.34 (8.04%)
shortest_path_ldbc100 q38 405.93 491.79 -85.86 (-17.46%)
shortest_path_ldbc100 q39 56.19 59.86 -3.67 (-6.13%)
shortest_path_ldbc100 q40 359.40 546.92 -187.52 (-34.29%)
var_size_expr_evaluator q03 2110.86 2056.88 53.97 (2.62%)
var_size_expr_evaluator q04 2288.04 2217.98 70.06 (3.16%)
var_size_expr_evaluator q05 2665.03 2583.63 81.41 (3.15%)
var_size_expr_evaluator q06 1344.21 1334.42 9.79 (0.73%)
var_size_seq_scan q19 1475.45 1456.96 18.49 (1.27%)
var_size_seq_scan q20 2446.17 2566.20 -120.03 (-4.68%)
var_size_seq_scan q21 2277.75 2283.56 -5.81 (-0.25%)
var_size_seq_scan q22 127.51 127.12 0.39 (0.31%)

@royi-luo royi-luo marked this pull request as ready for review November 20, 2024 20:04
@royi-luo royi-luo requested review from ray6080 and benjaminwinger and removed request for benjaminwinger November 20, 2024 20:04
royi-luo added 19 commits December 2, 2024 10:18
@royi-luo
Actually pass rollback insert callback
8c72b07
@royi-luo
Add second layer of iterators to undo buffer
ffd0cd5
@royi-luo
Bug fixes + code cleanup
739b5d8
@royi-luo
Cleanup node table + actually use semi mask
14fb9a1
@royi-luo
Actually enable semi mask
76ed7d0
@royi-luo
Self-review
5a1e353
@royi-luo
Add tests
a87f669
@royi-luo
Reclaim overflow slots in in-mem hash index after delete
07cef58
@royi-luo
Address review comments
a91e448
@royi-luo
Replace construct iterator callback with virtual class
9134abb
@royi-luo
Refactor version record handler
c3c638e
@royi-luo
Refactor version record handler again
89f713f
@royi-luo
Rollback insert for node groups
08757c3
@royi-luo
Remove unused forward declares
6b30e35
@royi-luo
Get correct num of total rows to rollback in node group collection
1a55443
@royi-luo
Make BM exception during rel commit trigger earlier
84b6e17
@royi-luo
Update num total rows for rel table data node group collection
40691ca
@royi-luo
Address review comments
4ad2632
@royi-luo
Rework nextChainedSlots() for in mem hash index
c052e90
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024

Benchmark Result

Master commit hash: f5224d7a5fa6ae548595a53a3ef66940ea76298c
Branch commit hash: ffbcbdc07e44541937ec00682c42ec1f68fad12b

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 651.70 645.19 6.52 (1.01%)
aggregation q28 11367.37 12090.73 -723.37 (-5.98%)
filter q14 132.68 129.42 3.26 (2.52%)
filter q15 135.07 125.10 9.97 (7.97%)
filter q16 311.59 303.81 7.78 (2.56%)
filter q17 452.03 446.34 5.69 (1.27%)
filter q18 1917.90 1944.01 -26.11 (-1.34%)
filter zonemap-node 94.64 87.37 7.27 (8.32%)
filter zonemap-node-lhs-cast 94.40 86.43 7.97 (9.22%)
filter zonemap-rel 5674.49 5683.28 -8.78 (-0.15%)
fixed_size_expr_evaluator q07 579.81 572.20 7.61 (1.33%)
fixed_size_expr_evaluator q08 811.42 800.76 10.67 (1.33%)
fixed_size_expr_evaluator q09 812.49 799.31 13.18 (1.65%)
fixed_size_expr_evaluator q10 245.08 235.69 9.39 (3.98%)
fixed_size_expr_evaluator q11 236.72 229.25 7.47 (3.26%)
fixed_size_expr_evaluator q12 235.20 226.24 8.96 (3.96%)
fixed_size_expr_evaluator q13 1462.31 1462.18 0.13 (0.01%)
fixed_size_seq_scan q23 121.95 111.27 10.68 (9.60%)
join q29 623.71 634.27 -10.57 (-1.67%)
join q30 1273.36 1411.20 -137.84 (-9.77%)
join q31 5.30 8.31 -3.01 (-36.25%)
ldbc_snb_ic q35 399.72 389.63 10.09 (2.59%)
ldbc_snb_ic q36 119.93 130.78 -10.85 (-8.29%)
ldbc_snb_is q32 2.40 6.32 -3.93 (-62.10%)
ldbc_snb_is q33 13.96 16.31 -2.36 (-14.43%)
ldbc_snb_is q34 1.03 1.56 -0.53 (-33.90%)
multi-rel multi-rel-large-scan 1211.54 1234.34 -22.80 (-1.85%)
multi-rel multi-rel-lookup 17.12 36.34 -19.22 (-52.89%)
multi-rel multi-rel-small-scan 95.56 75.58 19.98 (26.44%)
order_by q25 139.87 127.31 12.56 (9.86%)
order_by q26 460.93 451.05 9.88 (2.19%)
order_by q27 1463.90 1488.44 -24.54 (-1.65%)
scan_after_filter q01 177.21 170.84 6.37 (3.73%)
scan_after_filter q02 165.18 156.11 9.07 (5.81%)
shortest_path_ldbc100 q37 83.73 77.07 6.66 (8.64%)
shortest_path_ldbc100 q38 462.50 465.41 -2.91 (-0.62%)
shortest_path_ldbc100 q39 60.45 62.52 -2.07 (-3.32%)
shortest_path_ldbc100 q40 500.89 488.53 12.37 (2.53%)
var_size_expr_evaluator q03 2071.63 2087.07 -15.44 (-0.74%)
var_size_expr_evaluator q04 2237.84 2249.96 -12.12 (-0.54%)
var_size_expr_evaluator q05 2708.53 2636.28 72.25 (2.74%)
var_size_expr_evaluator q06 1343.35 1354.27 -10.91 (-0.81%)
var_size_seq_scan q19 1466.04 1471.05 -5.01 (-0.34%)
var_size_seq_scan q20 2701.24 2683.86 17.38 (0.65%)
var_size_seq_scan q21 2275.15 2286.81 -11.67 (-0.51%)
var_size_seq_scan q22 127.03 127.72 -0.69 (-0.54%)

@royi-luo royi-luo force-pushed the royi/rollback-hash-index branch from 0ea3af1 to cec96e5 Compare December 2, 2024 16:04
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024

Benchmark Result

Master commit hash: f5224d7a5fa6ae548595a53a3ef66940ea76298c
Branch commit hash: 0b0e22c16263b045f4fe6f9da6d4a3d9a266569f

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 654.21 645.19 9.03 (1.40%)
aggregation q28 11307.47 12090.73 -783.26 (-6.48%)
filter q14 134.26 129.42 4.84 (3.74%)
filter q15 132.86 125.10 7.76 (6.21%)
filter q16 324.60 303.81 20.79 (6.84%)
filter q17 455.41 446.34 9.07 (2.03%)
filter q18 1923.32 1944.01 -20.69 (-1.06%)
filter zonemap-node 95.94 87.37 8.57 (9.81%)
filter zonemap-node-lhs-cast 96.75 86.43 10.32 (11.94%)
filter zonemap-rel 5650.35 5683.28 -32.92 (-0.58%)
fixed_size_expr_evaluator q07 578.63 572.20 6.44 (1.12%)
fixed_size_expr_evaluator q08 808.64 800.76 7.89 (0.98%)
fixed_size_expr_evaluator q09 807.93 799.31 8.62 (1.08%)
fixed_size_expr_evaluator q10 243.88 235.69 8.19 (3.47%)
fixed_size_expr_evaluator q11 236.98 229.25 7.74 (3.37%)
fixed_size_expr_evaluator q12 234.15 226.24 7.91 (3.49%)
fixed_size_expr_evaluator q13 1456.42 1462.18 -5.76 (-0.39%)
fixed_size_seq_scan q23 116.23 111.27 4.96 (4.45%)
join q29 604.64 634.27 -29.63 (-4.67%)
join q30 1350.30 1411.20 -60.90 (-4.32%)
join q31 6.17 8.31 -2.14 (-25.78%)
ldbc_snb_ic q35 497.52 389.63 107.89 (27.69%)
ldbc_snb_ic q36 122.72 130.78 -8.06 (-6.17%)
ldbc_snb_is q32 5.14 6.32 -1.18 (-18.70%)
ldbc_snb_is q33 14.97 16.31 -1.35 (-8.25%)
ldbc_snb_is q34 1.51 1.56 -0.05 (-3.26%)
multi-rel multi-rel-large-scan 1197.14 1234.34 -37.20 (-3.01%)
multi-rel multi-rel-lookup 18.19 36.34 -18.15 (-49.95%)
multi-rel multi-rel-small-scan 97.70 75.58 22.13 (29.28%)
order_by q25 137.48 127.31 10.17 (7.99%)
order_by q26 455.77 451.05 4.72 (1.05%)
order_by q27 1461.22 1488.44 -27.23 (-1.83%)
scan_after_filter q01 176.65 170.84 5.82 (3.41%)
scan_after_filter q02 165.08 156.11 8.97 (5.75%)
shortest_path_ldbc100 q37 82.24 77.07 5.17 (6.71%)
shortest_path_ldbc100 q38 485.24 465.41 19.84 (4.26%)
shortest_path_ldbc100 q39 59.94 62.52 -2.58 (-4.13%)
shortest_path_ldbc100 q40 525.86 488.53 37.34 (7.64%)
var_size_expr_evaluator q03 2051.88 2087.07 -35.19 (-1.69%)
var_size_expr_evaluator q04 2217.27 2249.96 -32.70 (-1.45%)
var_size_expr_evaluator q05 2523.07 2636.28 -113.21 (-4.29%)
var_size_expr_evaluator q06 1339.04 1354.27 -15.23 (-1.12%)
var_size_seq_scan q19 1443.95 1471.05 -27.09 (-1.84%)
var_size_seq_scan q20 2685.05 2683.86 1.19 (0.04%)
var_size_seq_scan q21 2290.48 2286.81 3.66 (0.16%)
var_size_seq_scan q22 127.61 127.72 -0.11 (-0.08%)

@royi-luo royi-luo merged commit a82a76a into master Dec 2, 2024
24 of 25 checks passed
@royi-luo royi-luo deleted the royi/rollback-hash-index branch December 2, 2024 19:21
@ray6080 ray6080 mentioned this pull request Dec 11, 2024
Merged
ray6080 pushed a commit that referenced this pull request Dec 17, 2024
@royi-luo @ray6080
Fix rollback during Node Table COPY (#4467)
af92428
ray6080 pushed a commit that referenced this pull request Dec 18, 2024
@royi-luo @ray6080
Fix rollback during Node Table COPY (#4467)
26fc7fe
@royi-luo royi-luo mentioned this pull request Jan 16, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminwinger benjaminwinger benjaminwinger approved these changes

@ray6080 ray6080 ray6080 approved these changes

Assignees

@royi-luo royi-luo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Buffer manager allocation failures causing corruption
3 participants
@royi-luo @ray6080 @benjaminwinger