Fix VersionInfo SelectionVector creation #4556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One branch of the code was setting the existing SelectionVector to filtered and then appending to it Existing unfiltered elements would be discarded and replaced with whatever happened to be in the SelectionVector's mutable buffer
benjaminwinger
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4556 +/- ##
==========================================
- Coverage 87.35% 87.35% -0.01%
==========================================
Files 1349 1349
Lines 56584 56587 +3
Branches 7081 7079 -2
==========================================
+ Hits 49431 49433 +2
Misses 6981 6981
- Partials 172 173 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Benchmark ResultMaster commit hash:
|
ray6080
pushed a commit
that referenced
this pull request
Dec 17, 2024
One branch of the code was setting the existing SelectionVector to filtered and then appending to it Existing unfiltered elements would be discarded and replaced with whatever happened to be in the SelectionVector's mutable buffer
ray6080
pushed a commit
that referenced
this pull request
Dec 18, 2024
One branch of the code was setting the existing SelectionVector to filtered and then appending to it Existing unfiltered elements would be discarded and replaced with whatever happened to be in the SelectionVector's mutable buffer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4271.
The issue was that
VersionInfo::getSelVectorForScan(andVectorVersionInfo::getSelVectorForScan) append repeatedly to aSelectionVectorand in certain circumstances it will turn a non-empty unfiltered SelectionVector into a filtered one without preserving the former values and then just appending to the end. My solution was to add a new makeDynamic function that copies the old selectedPositions into the mutable buffer before switching them.E.g. this can occur when the first few VectorVersionInfos have no deletions, such that the first branch is taken in
VectorVersionInfo::getSelVectorToScanand it just increases the length of the unfiltered SelectionVector, but then later VectorVersionInfos have deletions, taking the second branch where there is no check for unfiltered data (since it has to be converted to filtered at that point).