-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement FORMAT
option in LOAD FROM
clause.
#4613
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4613 +/- ##
==========================================
+ Coverage 87.38% 87.40% +0.02%
==========================================
Files 1363 1363
Lines 57608 57614 +6
Branches 7184 7185 +1
==========================================
+ Hits 50340 50357 +17
+ Misses 7102 7091 -11
Partials 166 166 ☔ View full report in Codecov by Sentry. |
Benchmark ResultMaster commit hash:
|
} catch (...) { | ||
if (typeInfo.fileTypeStr == "") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cover
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is already covered by extension test which doesn't show up correctly in codecov
This PR implements the
LOAD FROM
clause withFORMAT
option as described in #4597 .resolves #4597
Usage:
format
option is not given, kuzu tries to sniff the file format using the file extension. e.g.test.csv
=> kuzu treats it asCSV
format since it ends with.CSV
.format
option is given, kuzu uses theformat
option instead of doing the sniffing.