Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e-notation double #4616

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Add e-notation double #4616

merged 2 commits into from
Dec 10, 2024

Conversation

andyfengHKU
Copy link
Contributor

@andyfengHKU andyfengHKU commented Dec 10, 2024

Description

Fixes #4593

Contributor agreement

Copy link

Benchmark Result

Master commit hash: 0a68e245da2c1c3920ee863b61085ccb3a74f5c4
Branch commit hash: 68958dc6c2f7b5476fd671012b0f48755570805f

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 647.97 634.93 13.03 (2.05%)
aggregation q28 11645.95 11424.37 221.59 (1.94%)
filter q14 124.94 119.39 5.54 (4.64%)
filter q15 126.19 117.76 8.43 (7.16%)
filter q16 301.94 303.27 -1.33 (-0.44%)
filter q17 444.33 437.78 6.54 (1.49%)
filter q18 1895.33 1865.39 29.94 (1.60%)
filter zonemap-node 88.63 78.15 10.49 (13.42%)
filter zonemap-node-lhs-cast 86.56 78.37 8.19 (10.45%)
filter zonemap-rel 5692.28 5759.73 -67.45 (-1.17%)
fixed_size_expr_evaluator q07 573.63 565.12 8.52 (1.51%)
fixed_size_expr_evaluator q08 800.24 793.63 6.61 (0.83%)
fixed_size_expr_evaluator q09 803.81 793.17 10.64 (1.34%)
fixed_size_expr_evaluator q10 237.64 231.26 6.38 (2.76%)
fixed_size_expr_evaluator q11 230.94 222.61 8.32 (3.74%)
fixed_size_expr_evaluator q12 225.50 219.97 5.54 (2.52%)
fixed_size_expr_evaluator q13 1452.56 1446.87 5.69 (0.39%)
fixed_size_seq_scan q23 111.93 106.72 5.21 (4.88%)
join q29 621.74 587.07 34.66 (5.90%)
join q30 1603.63 1525.13 78.49 (5.15%)
join q31 6.65 5.48 1.17 (21.37%)
ldbc_snb_ic q35 2554.81 2628.31 -73.50 (-2.80%)
ldbc_snb_ic q36 564.15 529.62 34.54 (6.52%)
ldbc_snb_is q32 5.47 1.97 3.50 (177.35%)
ldbc_snb_is q33 11.28 10.33 0.95 (9.18%)
ldbc_snb_is q34 1.22 0.80 0.42 (52.68%)
multi-rel multi-rel-large-scan 1193.93 1517.64 -323.72 (-21.33%)
multi-rel multi-rel-lookup 20.44 34.95 -14.50 (-41.50%)
multi-rel multi-rel-small-scan 93.16 81.01 12.14 (14.99%)
order_by q25 128.43 120.43 8.00 (6.64%)
order_by q26 466.03 439.96 26.07 (5.93%)
order_by q27 1475.61 1440.01 35.60 (2.47%)
recursive_join recursive-join-bidirection 281.29 291.62 -10.33 (-3.54%)
recursive_join recursive-join-dense 5136.48 7431.00 -2294.52 (-30.88%)
recursive_join recursive-join-path 22823.43 23861.20 -1037.76 (-4.35%)
recursive_join recursive-join-sparse 13864.02 14295.94 -431.92 (-3.02%)
recursive_join recursive-join-trail 5436.24 7361.40 -1925.16 (-26.15%)
scan_after_filter q01 170.56 163.61 6.95 (4.25%)
scan_after_filter q02 156.93 150.93 5.99 (3.97%)
shortest_path_ldbc100 q37 99.59 83.68 15.91 (19.01%)
shortest_path_ldbc100 q38 315.29 254.41 60.89 (23.93%)
shortest_path_ldbc100 q39 59.32 41.19 18.13 (44.02%)
shortest_path_ldbc100 q40 371.35 262.38 108.96 (41.53%)
var_size_expr_evaluator q03 2076.18 2042.94 33.24 (1.63%)
var_size_expr_evaluator q04 2217.11 2180.86 36.25 (1.66%)
var_size_expr_evaluator q05 2658.07 2586.85 71.22 (2.75%)
var_size_expr_evaluator q06 1319.89 1340.93 -21.05 (-1.57%)
var_size_seq_scan q19 1438.15 1427.02 11.12 (0.78%)
var_size_seq_scan q20 2672.70 2683.74 -11.04 (-0.41%)
var_size_seq_scan q21 2300.96 2329.01 -28.05 (-1.20%)
var_size_seq_scan q22 125.16 124.94 0.21 (0.17%)

@andyfengHKU andyfengHKU merged commit 6a4685b into master Dec 10, 2024
@andyfengHKU andyfengHKU deleted the add-e-notation-double branch December 10, 2024 16:14
ray6080 pushed a commit that referenced this pull request Dec 17, 2024
* Add e-notation double

* Run clang-format

---------

Co-authored-by: CI Bot <[email protected]>
ray6080 pushed a commit that referenced this pull request Dec 18, 2024
* Add e-notation double

* Run clang-format

---------

Co-authored-by: CI Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Cannot handle floating point values with E notation
2 participants