-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trim Unnecessary Quote for CLI JSON output #4643
Conversation
Benchmark ResultMaster commit hash:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4643 +/- ##
=======================================
Coverage 86.51% 86.51%
=======================================
Files 1369 1369
Lines 57983 57983
Branches 7209 7208 -1
=======================================
+ Hits 50165 50166 +1
+ Misses 7650 7649 -1
Partials 168 168 ☔ View full report in Codecov by Sentry. |
b8c94d5
to
d3e8824
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Benchmark ResultMaster commit hash:
|
Description
Before, in
printJsonExecutionResult
, we always add quotes to the value, instead, we should only add these quotes when the value is a string or a blob.Fixes #4634
Contributor agreement