Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KZL-907] Getting started dev plugin #276

Merged
merged 23 commits into from
Apr 26, 2019
Merged

Conversation

Yoann-Abbes
Copy link
Contributor

@Yoann-Abbes Yoann-Abbes commented Apr 10, 2019

What does this PR do?

This PR responds to this ticket.
Also, it increases the readability of documentation's plugin part.

How should this be manually tested?

Netify

Other changes

  • Re-arrange plugin documentation path
  • Update dead link in boilerplate repository

Boyscout

Prettier

@kuzzle
Copy link
Contributor

kuzzle commented Apr 10, 2019

Snippets tests reports

SDK Version Tests overview
v6 ✔️
v5 ✔️
v1 ✔️
v1 ✔️
v1 ✔️
v1 ✔️

@Yoann-Abbes Yoann-Abbes removed the wip label Apr 15, 2019
Copy link
Contributor

@benoitvidis benoitvidis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is probably just me, but the previous version was looking simpler to me, especially by having a dedicated "Getting started" page.

src/plugins/1/plugin-layout/prerequis/index.md Outdated Show resolved Hide resolved
src/plugins/1/strategies/index.md Show resolved Hide resolved
@Yoann-Abbes Yoann-Abbes added wip and removed wip labels Apr 16, 2019

<div class="alert alert-info">
You can find more information about the <code>init</code> function <a href="https://docs.kuzzle.io/plugins/1/plugin-layout/init-function/"> here</a>.
</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! :trollface:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to the markdown master 🥇

@Yoann-Abbes Yoann-Abbes requested a review from benoitvidis April 16, 2019 15:01
Copy link
Contributor

@scottinet scottinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • When clicking on a deployable menu (for instance, Plugin Layout), the Plugin menu head disappears.
  • That Plugins entry should be a separator IMO
  • the Introduction page still mentions "chapters", but it should now be "pages"
  • I'm not sure that the term boilerplate is widespread enough to use it as a menu entry (dictionary definition ). I would replace the Plugin Boilerplate menu entry with Getting Started
  • Plugin Layout is not bad per se, but I don't find it clear enough... To be debated, but I would propose something like Manual setup

@Yoann-Abbes Yoann-Abbes requested a review from scottinet April 17, 2019 12:50
@Yoann-Abbes Yoann-Abbes requested a review from Aschen April 17, 2019 14:20
src/plugins/1/essentials/getting-started/index.md Outdated Show resolved Hide resolved
src/plugins/1/essentials/getting-started/index.md Outdated Show resolved Hide resolved
Copy link
Contributor

@scottinet scottinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another requested change: Hooks, Pipes and Controllers documentation are now in the Essentials menu, while Strategies are described at root level. These 4 items should always be at the same level, because they are about different plugins features, there is nothing fundamentally different about them.

src/plugins/1/essentials/getting-started/index.md Outdated Show resolved Hide resolved
src/plugins/1/essentials/getting-started/index.md Outdated Show resolved Hide resolved
src/plugins/1/essentials/getting-started/index.md Outdated Show resolved Hide resolved
src/plugins/1/essentials/getting-started/index.md Outdated Show resolved Hide resolved
src/plugins/1/essentials/hooks/index.md Outdated Show resolved Hide resolved
@Yoann-Abbes
Copy link
Contributor Author

Yoann-Abbes commented Apr 24, 2019

@scottinet apparently it's not possible to have 3 levels like Essentials->Strategies->Overview. The menu does not support it without losing the head menu
Plus, is it good to have 3 depth levels ?
Since we want the authentication methods in a separate file, i can't have Strategies in a single file to prevent a third level.

@scottinet
Copy link
Contributor

Then move the others out of Essentials

@Yoann-Abbes Yoann-Abbes requested a review from scottinet April 24, 2019 12:35
@Yoann-Abbes Yoann-Abbes requested a review from scottinet April 25, 2019 23:33
@scottinet scottinet merged commit 15bb02b into 2-dev Apr 26, 2019
@scottinet scottinet deleted the KZL-907-plugin-getting-started branch April 26, 2019 12:57
@kuzzle kuzzle mentioned this pull request Apr 29, 2019
alexandrebouthinon pushed a commit that referenced this pull request Apr 29, 2019
* Add documentation page about mappings (#271)

Adds a documentation essentials page about mappings:

dynamic mapping policy
collection metadata
properties types definitions
Also update SDKs

See kuzzleio/kuzzle#1257

* Embedded protocols (#286)

Documentation for embedded protocols, notably for MQTT.

* Extending the JS SDK with controllers (#284)

Add a page about how to extend the JS SDK with custom controllers.  
https://deploy-preview-284--kuzzle-doc-v2.netlify.com/sdk-reference/js/6/extend-sdk/

Also document:
 - BaseController class
 - Kuzzle.useController method

See kuzzleio/sdk-javascript#388

* [KZL-907] Getting started dev plugin (#276)

## What does this PR do?

This PR responds to this [ticket](https://jira.kaliop.net/browse/KZL-907).
Also, it increases the readability of documentation's plugin part.

### How should this be manually tested?

[Netify](https://deploy-preview-276--kuzzle-doc-v2.netlify.com/plugins/1/essentials/introduction/)

### Other changes

- Re-arrange plugin documentation path
- Update dead link in boilerplate repository

### Boyscout

Prettier

* Release 2.1.1
This was referenced Jun 12, 2019
xbill82 added a commit that referenced this pull request Jun 13, 2019
# [3.0.0](https://github.com/kuzzleio/documentation/releases/tag/3.0.0) (2019-06-12)


#### Bug fixes

- [ [#298](#298) ] Fix bulk import return   ([Aschen](https://github.com/Aschen))
- [ [#325](#325) ] Adapt legacy redirection   ([Aschen](https://github.com/Aschen))
- [ [#322](#322) ] Fix remaining dead links and add check_link to CI   ([Aschen](https://github.com/Aschen))
- [ [#304](#304) ] Fix sdk js tests   ([benoitvidis](https://github.com/benoitvidis))

#### New features

- [ [#299](#299) ] Documentation for wildcard events   ([thomasarbona](https://github.com/thomasarbona))
- [ [#321](#321) ] Add guide about secrets management with the Vault   ([Aschen](https://github.com/Aschen))
- [ [#300](#300) ] Add page about bulk:write and bulk:mwrite   ([Aschen](https://github.com/Aschen))

#### Enhancements

- [ [#327](#327) ] SPA mode   ([xbill82](https://github.com/xbill82))
- [ [#324](#324) ] Update Redis version   ([Aschen](https://github.com/Aschen))
- [ [#316](#316) ] Sdks authenticated connected props   ([Aschen](https://github.com/Aschen))
- [ [#317](#317) ] Add new way for updateSpecifications & validateSpecifications   ([thomasarbona](https://github.com/thomasarbona))
- [ [#296](#296) ] Rewrite the Realtime guide   ([Aschen](https://github.com/Aschen))
- [ [#301](#301) ] Deprecate realtime join   ([Aschen](https://github.com/Aschen))
- [ [#291](#291) ] Getting started React + improve snippetManager   ([thomasarbona](https://github.com/thomasarbona))
- [ [#294](#294) ] Add s3 plugin   ([Aschen](https://github.com/Aschen))
- [ [#292](#292) ] Add since   ([Aschen](https://github.com/Aschen))
- [ [#276](#276) ] [KZL-907] Getting started dev plugin   ([Yoann-Abbes](https://github.com/Yoann-Abbes))
- [ [#284](#284) ] Extending the JS SDK with controllers   ([Aschen](https://github.com/Aschen))
- [ [#271](#271) ] Add documentation page about mappings   ([Aschen](https://github.com/Aschen))

#### Others

- [ [#314](#314) ] Add a clustering guide   ([scottinet](https://github.com/scottinet))
- [ [#319](#319) ] Getting-started-sdk-JS6-architecture   ([berthieresteban](https://github.com/berthieresteban))
- [ [#311](#311) ] Add PDF sending example for Request.setResult   ([Aschen](https://github.com/Aschen))
- [ [#315](#315) ] Normalize directories and generate redirections   ([Aschen](https://github.com/Aschen))
- [ [#309](#309) ] Port #284 to 3-dev   ([berthieresteban](https://github.com/berthieresteban))
- [ [#308](#308) ] Port #283 to 3-dev   ([berthieresteban](https://github.com/berthieresteban))
- [ [#307](#307) ] Port #282 to 3-dev   ([berthieresteban](https://github.com/berthieresteban))
- [ [#306](#306) ] Port #280 to 3-dev   ([berthieresteban](https://github.com/berthieresteban))
- [ [#312](#312) ] Port 278 to 3-dev   ([Aschen](https://github.com/Aschen))
- [ [#310](#310) ] Port #277 to 3-dev   ([Aschen](https://github.com/Aschen))
- [ [#305](#305) ] Port #275 to 3-dev   ([Aschen](https://github.com/Aschen))
- [ [#303](#303) ] Port #274 to 3-dev   ([Aschen](https://github.com/Aschen))
- [ [#302](#302) ] Port #271 to 3-dev   ([Aschen](https://github.com/Aschen))
- [ [#313](#313) ] Port #266 to 3-dev   ([Yoann-Abbes](https://github.com/Yoann-Abbes))
- [ [#290](#290) ] [KZL-1050] Role template example in the documentation   ([Yoann-Abbes](https://github.com/Yoann-Abbes))
- [ [#293](#293) ] [KZL-1036] Add available plugins   ([Yoann-Abbes](https://github.com/Yoann-Abbes))
- [ [#286](#286) ] Embedded protocols   ([benoitvidis](https://github.com/benoitvidis))
---
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants