Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOTFIX] Fix a bug which sometimes doesn't display the list of collection in an not empty index #506

Merged
merged 2 commits into from
Mar 13, 2019

Conversation

jenow
Copy link
Contributor

@jenow jenow commented Mar 11, 2019

What does this PR do ?

Because the count of indexes and collections is async it happens sometimes when clicking on an index that the count of collection is not done.
So now if the value of IndexesAndCollection of the store is not yet stored we dispatch the action of getting it.

Note

I didn't change the version as I am going to do a batch of hotfix before patching this version

@jenow jenow self-assigned this Mar 11, 2019
@codecov-io
Copy link

codecov-io commented Mar 11, 2019

Codecov Report

Merging #506 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #506   +/-   ##
=======================================
  Coverage   84.11%   84.11%           
=======================================
  Files          35       35           
  Lines         793      793           
=======================================
  Hits          667      667           
  Misses        126      126

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2d679f...269c37e. Read the comment docs.

@jenow jenow changed the title [HOTFIX] Fix the count of collection in an [HOTFIX] Fix a bug which sometimes didn't display the list of collection in an not empty index Mar 11, 2019
@jenow jenow changed the title [HOTFIX] Fix a bug which sometimes didn't display the list of collection in an not empty index [HOTFIX] Fix a bug which sometimes doesn't display the list of collection in an not empty index Mar 11, 2019
@jenow jenow merged commit 2b1db01 into master Mar 13, 2019
@jenow jenow deleted the fix-list-collection-async branch March 13, 2019 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants