Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOTFIX] Update a document instead of replacing it #507

Merged
merged 1 commit into from
Mar 13, 2019
Merged

Conversation

jenow
Copy link
Contributor

@jenow jenow commented Mar 13, 2019

What does this PR do ?

To update a document we use replaceDocument which has the effect to change the meta data author.
The proper behavior should be that the meta data updater is updated.
This fix simply do a updateDocument instead of a replaceDocument.

fix #495

@jenow jenow self-assigned this Mar 13, 2019
@codecov-io
Copy link

codecov-io commented Mar 13, 2019

Codecov Report

Merging #507 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #507   +/-   ##
=======================================
  Coverage   84.11%   84.11%           
=======================================
  Files          35       35           
  Lines         793      793           
=======================================
  Hits          667      667           
  Misses        126      126

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b1db01...e14d5ff. Read the comment docs.

@scottinet scottinet merged commit 4cb42a2 into master Mar 13, 2019
@scottinet scottinet deleted the fix-495 branch March 13, 2019 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating a document changes its author
4 participants