Allow to search on _id in AdvancedFilter #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xbill82
reviewed
Jul 15, 2021
| filterToAdd = { | ||
| range: { | ||
| [filter.attribute]: { | ||
| gte: filter.value, |
There was a problem hiding this comment.
What if the type of the field is not numeric?
There was a problem hiding this comment.
I didn't change the logic in that part, I just refactored it using a switch case
you can see here that the 3 else if of equal not_equal and range where using a ES range filter so I let that filter.
If we need to change that, I would prefer doing it in another PR
xbill82
approved these changes
Jul 15, 2021
Njuelle
approved these changes
Jul 26, 2021
Closed
Aschen
added a commit
that referenced
this pull request
Nov 2, 2021
# [4.3.0](https://github.com/kuzzleio/kuzzle-admin-console/releases/tag/4.3.0) (2021-11-02) #### Bug fixes - [ [#959](#959) ] Add dropdown-view to realtime document view ([berthieresteban](https://github.com/berthieresteban)) - [ [#968](#968) ] Redirect to Login page if token expired ([alexandrebouthinon](https://github.com/alexandrebouthinon)) - [ [#935](#935) ] Add loader to documnent list while fetching ([berthieresteban](https://github.com/berthieresteban)) - [ [#934](#934) ] Add loader and disable modal buttons ([berthieresteban](https://github.com/berthieresteban)) #### New features - [ [#951](#951) ] Allow to search on _id in AdvancedFilter ([berthieresteban](https://github.com/berthieresteban)) - [ [#949](#949) ] Display geo shapes on map view ([berthieresteban](https://github.com/berthieresteban)) - [ [#953](#953) ] Add feedback dropdown ([berthieresteban](https://github.com/berthieresteban)) #### Enhancements - [ [#970](#970) ] Store Current environment in session storage instead of local storage ([alexandrebouthinon](https://github.com/alexandrebouthinon)) - [ [#950](#950) ] Delete index dropdown ([berthieresteban](https://github.com/berthieresteban)) - [ [#960](#960) ] Enhance advanced filter ([berthieresteban](https://github.com/berthieresteban)) - [ [#952](#952) ] Allow to hide the No Admin Banner ([berthieresteban](https://github.com/berthieresteban)) - [ [#936](#936) ] Prefill raw filter with query and sort ([berthieresteban](https://github.com/berthieresteban)) - [ [#953](#953) ] Add feedback dropdown ([berthieresteban](https://github.com/berthieresteban)) - [ [#948](#948) ] Persist left Sidebar size in the local storage ([jsatge](https://github.com/jsatge)) #### Others - [ [#976](#976) ] Bump Kuzzle SDK version ([xbill82](https://github.com/xbill82)) - [ [#922](#922) ] Fix initial filter displayed value issue ([berthieresteban](https://github.com/berthieresteban)) ---
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #947
Allow to search on _id in AdvancedFilter
⚠️ doesn't work for a partial match since _id field can only be search following
term,terms,matchandquery_string