feat(deviceManagerEngine): free devices after engine deletion

[QuentinRousselet]

What does this PR do ?

Unassign all the devices from their engineId and assetId in the admin index when the deviceManagerEngine is deleted after the deletion of its collections.

How should this be manually tested?

• Step 1 : Create a device-manager-engine
• Step 2 : Add attach several devices to it and assign them to some assets
• Step 3 : Delete the engine
• Step 4 : Check in the admin index in the device collection that all former devices don't have any engineId or assetId anymore.

KZLPRD-511

[rolljee]

I feel like this should not be done inside the kuzzle-device-manager plugins because here you create a dependency with the multi-tenancy plugin witch is not the purpose of this plugin. It is suppose to be autonomous. You should put this behaviour in the iot platform backend

[QuentinRousselet]

Indeed, this was the first implementation but supposed to be removed for the reason you gave
My bad, I messed up my last commit...

[etrousset]

I feel like this method should be named detachDevicesFromTenantIndex

[QuentinRousselet]

I think tenantIndex could lead to confusion as this functions is related only to the 'platform' index which is referred as adminIndex in KDM.

[Juiced66]

It could be so cool to implement a dependancies property at model level that registers cleaning hooks itself. That way user can register is own dependancies and clean all business deps + system deps
Could be done for all entities of KDM

[rolljee]

It could be so cool to implement a dependancies property at model level that registers cleaning hooks itself. That way user can register is own dependancies and clean all business deps + system deps Could be done for all entities of KDM

Could you elaborate on this ? i think i didn't get it properly

[Juiced66]

It could be so cool to implement a dependancies property at model level that registers cleaning hooks itself. That way user can register is own dependancies and clean all business deps + system deps Could be done for all entities of KDM

Could you elaborate on this ? i think i didn't get it properly

It could be a kind of service wich we can pass a trigger (create, delete ...) and a callback wich is invoke when the action is trigger. That way we structurate system cleaning and we will be able to easily open it to user with a registerDependancy method
The idea is if an asset for example should add a workflow on create, we can register there dependancy and register also a cleaning callback when asset is removed for example.

that's fully possible to do it manually for now but it could structure the process and be easier for developpers IMHO

For me we address a sytem dependancy in this PR

[rolljee]

You need to add a test for this :) otherwise look good to me

[rolljee]

What is the state of this PR ?

[QuentinRousselet]

What is the state of this PR ?

Waiting for other reviews now that I added tests as requested