Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: lastMeasuredAt #387

Open
wants to merge 2 commits into
base: 3-dev
Choose a base branch
from
Open

fix: lastMeasuredAt #387

wants to merge 2 commits into from

Conversation

thomas-mauran
Copy link
Member

This was creating a bug where if a payload with an older measure was received we would set lastMeasuredAt to 0

@thomas-mauran thomas-mauran self-assigned this Dec 26, 2024
rolljee
rolljee requested changes Dec 30, 2024
View reviewed changes
Copy link
Contributor

@rolljee rolljee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add a test for this case :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afondard afondard afondard approved these changes

@alexandrebouthinon alexandrebouthinon Awaiting requested review from alexandrebouthinon

@rolljee rolljee Awaiting requested review from rolljee

Assignees

@thomas-mauran thomas-mauran

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thomas-mauran @rolljee @afondard @QuentinRousselet