Features add bucket controller and signed urls to file:getUrl #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Juiced66
changed the title
Juiced66
changed the title
Juiced66
force-pushed
the
feat-add-bucket-controller
branch
from
745fa7e to
9a12c6c
Compare
…eio/kuzzle-plugin-s3 into feat-add-bucket-controller
rolljee
approved these changes
Jul 5, 2023
Aschen
reviewed
Jul 7, 2023
added 5 commits
July 10, 2023 06:39
Juiced66
commented
Jul 10, 2023
Juiced66
commented
Jul 10, 2023
|
|
||
| const params = { Bucket: bucketName }; | ||
|
|
||
| await this.s3.createBucket({ ...params, ...bucketOptions }).promise(); |
There was a problem hiding this comment.
yes it is intended to allow user use aws-sdk s3 options
lib/S3Plugin.js
Outdated
| if (err.code === 'NotFound') { | ||
| return false; | ||
| } | ||
| throw new this.context.errors.InternalError(err.message); |
Juiced66
changed the title
Aschen
reviewed
Jul 10, 2023
Closed
|
Is this PR intended to be merged in master at some point ? if not what would be the blocking points ? |
|
FYI I've had to add some stuff and I'm working on an update branch to handle bucket creation use cases properly: https://github.com/matgardon/kuzzle-plugin-s3/tree/feat/add-s3-bucket-controller |
|
I'll take a look to it @matgardon |
|
finally closed due to #33 wich's way more advanced |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Features :
Handle Signed URL to get files
Add Bucket controller :
/**
*/
/**
*/
-->
/**
*/
Boyscout
Add region to default config