Fix a concurrent modification error during reconnection (#44) (#45)

Co-authored-by: Tameem Rafay <[email protected]>
kuzzleio · Oct 22, 2020 · 9a48406 · 9a48406
1 parent f89ba57
commit 9a48406
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/lib/src/controllers/realtime.dart b/lib/src/controllers/realtime.dart
@@ -144,8 +144,12 @@ class RealTimeController extends KuzzleController {
             _currentSubscriptions[channel] = item;
             _subscriptionsCache[channel] = item;
           } else {
-            _currentSubscriptions[channel].add(subscription);
-            _subscriptionsCache[channel].add(subscription);
+            if (!_currentSubscriptions[channel].contains(subscription)) {
+              _currentSubscriptions[channel].add(subscription);
+            }
+            if (!_subscriptionsCache[channel].contains(subscription)) {
+              _subscriptionsCache[channel].add(subscription);
+            }
           }
           _rooms[roomId] = channel;
 
@@ -156,7 +160,9 @@ class RealTimeController extends KuzzleController {
 
   void _renewSubscribe() async {
     for (final subs in _subscriptionsCache.values) {
-      for (final sub in subs) {
+      final List<Subscription> _localSubs = List<Subscription>.from(subs);
+      subs.clear();
+      for (final sub in _localSubs) {
         await subscribe(
           sub.index,
           sub.collection,