Add document:upsert #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aschen
suggested changes
Dec 30, 2020
lib/src/controllers/document.dart
Outdated
| @@ -445,7 +447,8 @@ class DocumentController extends KuzzleController { | |||
| index: index, | |||
| collection: collection, | |||
| uid: id, | |||
| body: body, | |||
| body: changes, | |||
There was a problem hiding this comment.
The body contains both changes and defaults
lib/src/kuzzle/request.dart
Outdated
| @@ -200,7 +203,9 @@ class KuzzleRequest { | |||
| if (source != null) { | |||
| map['source'] = source; | |||
| } | |||
|
|
|||
| if (defaults != null) { | |||
| map['defaults'] = defaults; | |||
There was a problem hiding this comment.
I'm not sure to understand what this is suppose to do but defaults is part of the body and it looks like you put it in the arguments
Aschen
suggested changes
Dec 30, 2020
| | `_source` | <pre>Map<String, dynamic></pre> | Updated document (if `source` option set to true) | | ||
| | `_id` | <pre>String</pre> | ID of the udated document | | ||
| | `_version` | <pre>int</pre> | Version of the document in the persistent data storage | | ||
| | `created` | <pre>bool</pre> |
Co-authored-by: Adrien Maret <[email protected]>
xbill82
approved these changes
Jan 4, 2021
Aschen
approved these changes
Jan 5, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add document:upsert API action #55