Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom properties to a KuzzleRequest #72

Merged
merged 1 commit into from
Mar 1, 2021
Merged

Conversation

jenow
Copy link

@jenow jenow commented Mar 1, 2021

What does this PR do ?

Override the operators [] and []= to KuzzleRequest object to be able to add custom properties to the request outside of the body.

How should this be manually tested?

final request = KuzzleRequest(controller: 'test', action: 'test', body: {});
request['custom'] = 'foo';
final res = await kuzzle.query(request);

The custom field should be sent to kuzzle in the request.

Other changes

Add the documentation for KuzzleRequest

@jenow jenow requested review from Aschen and Yoann-Abbes March 1, 2021 14:27
@jenow jenow merged commit a8c0f9b into 2-dev Mar 1, 2021
@jenow jenow deleted the kuzzle-request-dynamic branch March 1, 2021 15:08
@jenow jenow mentioned this pull request Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants