Fix autoreconnect #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shiranuit
suggested changes
Apr 20, 2021
Shiranuit
suggested changes
Apr 20, 2021
Shiranuit
approved these changes
Apr 20, 2021
Shiranuit
approved these changes
Apr 20, 2021
Yoann-Abbes
approved these changes
Apr 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
fixes #83
The
disconnectedevent was not thrown in case of a manual disconnect.Also the auto reconnection logic was not working. I moved the logic of the reconnection from the abstract protocol class to the actual websocket protocol and now call the
reconnectedevent.