Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Java and Kotlin Getting started #23
Add Java and Kotlin Getting started #23
Changes from 5 commits
e01f407
891d3d7
cf40ae0
51e51f5
fe1b1d5
5409318
14ea4ba
5132317
ba9b572
c4d255b
935e839
ed14ed2
a53b351
abd0aff
3be54bd
4f4ef5b
f251ad4
1a5629d
9e47bd2
d4a122e
abd319f
f246fcb
fbf6b78
b289bb2
b76c2e1
a7687ca
9dfacfc
b15f6b8
3d94b3f
13dea72
94737fd
00331d8
3cf3601
06645f8
60ea453
5d850f7
0e4d1e1
92c03ed
22f3628
9575ebc
2540279
ce017bd
a5cff10
48a6996
661d0aa
0a56e04
8742683
5c0d8be
d1d6642
e4b5475
a294526
8da633c
a029905
ce905f0
b62e09b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably come earlier, before we make the user create an index and a collection. It'd probably be better to also link to a more detailed guide page, such as https://docs.kuzzle.io/core/2/guides/essentials/store-access-data/
That would give something like this (to be moved to the previous chapter):
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm... can the snippet serialize the document content and print it so that example gives a view of the actual notification content?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those are Kuzzle topics rather than SDK ones
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You r right, Ive copied this part from others SDK getting started, we should probably make it more accurate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.