Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support lang parameter for Koncorde filters #30

Merged
merged 26 commits into from
Feb 3, 2021

Conversation

Yoann-Abbes
Copy link
Contributor

@Yoann-Abbes Yoann-Abbes commented Dec 16, 2020

What does this PR do ?

Since Kuzzle 2.8.0 supports the "lang" parameter to handle Konkorde filters, we need to add it in SDKs for the API methods who accept it.

#40

Boyscout

Fix doc for mUpdate and updateByQuery

@Yoann-Abbes Yoann-Abbes marked this pull request as draft December 17, 2020 14:16
@Yoann-Abbes Yoann-Abbes changed the title Support lang parameter for Konkorde filters Support lang parameter for Koncorde filters Dec 18, 2020
@Yoann-Abbes Yoann-Abbes marked this pull request as ready for review January 13, 2021 14:18
@Leodau Leodau linked an issue Jan 13, 2021 that may be closed by this pull request
Copy link
Contributor

@Leodau Leodau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly some lapsus plumæ

doc/1/controllers/document/search/index.md Outdated Show resolved Hide resolved
doc/1/controllers/document/update-by-query/index.md Outdated Show resolved Hide resolved
doc/1/controllers/document/delete-by-query/index.md Outdated Show resolved Hide resolved
.ci/doc/templates/default.tpl.java Show resolved Hide resolved
@Yoann-Abbes Yoann-Abbes requested a review from jenow January 26, 2021 10:43
@jenow jenow merged commit 40868c1 into 1-dev Feb 3, 2021
@jenow jenow deleted the support-lang-parameter-for-konkorde-filters branch February 3, 2021 09:40
@Yoann-Abbes Yoann-Abbes mentioned this pull request Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support the "lang" parameter to handle Konkorde filters
4 participants