Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add document:upsert #38

Merged
merged 18 commits into from
Feb 22, 2021
Merged

Add document:upsert #38

merged 18 commits into from
Feb 22, 2021

Conversation

Yoann-Abbes
Copy link
Contributor

What does this PR do ?

Add document:upsert #37

Other changes

Revert wrong change on build.gradle.kts
Fix mUpdate and updateByQuery doc

Boyscout

Comment on lines +3 to +4
type: page
title: upsert
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing description

doc/1/controllers/document/upsert/index.md Outdated Show resolved Hide resolved
doc/1/controllers/document/upsert/index.md Outdated Show resolved Hide resolved
doc/1/controllers/document/upsert/index.md Outdated Show resolved Hide resolved
doc/1/controllers/document/upsert/index.md Outdated Show resolved Hide resolved
doc/1/controllers/document/upsert/index.md Outdated Show resolved Hide resolved
@Yoann-Abbes Yoann-Abbes requested a review from scottinet January 13, 2021 14:25
---
code: true
type: page
title: upsert
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing description

@Yoann-Abbes Yoann-Abbes requested a review from Aschen January 15, 2021 14:57
Comment on lines 33 to 38
public CompletableFuture<ConcurrentHashMap<String, ArrayList<Object>>> mUpdate(
String index,
String collection,
ArrayList<ConcurrentHashMap<String, Object>> documents,
Boolean waitForRefresh,
Integer retryOnConflict)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bad indentation

Comment on lines 23 to 27
public CompletableFuture<ConcurrentHashMap<String, ArrayList<Object>>> updateByQuery(
String index,
String collection,
ConcurrentHashMap<String, Object> searchQuery,
ConcurrentHashMap<String, Object> changes) throws NotConnectedException, InternalException
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bad indentation

Comment on lines 29 to 34
public CompletableFuture<ConcurrentHashMap<String, ArrayList<Object>>> updateByQuery(
String index,
String collection,
ConcurrentHashMap<String, Object> searchQuery,
ConcurrentHashMap<String, Object> changes,
Boolean waitForRefresh) throws NotConnectedException, InternalException
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bad indentation

Comment on lines 93 to 101
fun upsert(
index: String,
collection: String,
id: String,
changes: ConcurrentHashMap<String, Any?>,
defaults: ConcurrentHashMap<String, Any?>,
waitForRefresh: Boolean? = null,
retryOnConflict: Int? = null,
source: Boolean? = null): CompletableFuture<ConcurrentHashMap<String, Any?>>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bad indentation

Comment on lines 368 to 370
if (defaults != null) {

}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useless code

Comment on lines 12 to 15
kuzzle
.documentController
.upsert("nyc-open-data", "yellow-taxi", "some-id", changes)
.get()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing indentation

@Leodau Leodau linked an issue Jan 28, 2021 that may be closed by this pull request
@scottinet scottinet merged commit 1f6d152 into 1-dev Feb 22, 2021
@scottinet scottinet deleted the document-upsert branch February 22, 2021 09:05
@Yoann-Abbes Yoann-Abbes mentioned this pull request Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add document:upsert
6 participants