-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add document:upsert #38
Conversation
type: page | ||
title: upsert |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing description
Co-authored-by: Sébastien Cottinet <[email protected]>
Co-authored-by: Sébastien Cottinet <[email protected]>
Co-authored-by: Sébastien Cottinet <[email protected]>
Co-authored-by: Sébastien Cottinet <[email protected]>
Co-authored-by: Sébastien Cottinet <[email protected]>
--- | ||
code: true | ||
type: page | ||
title: upsert |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing description
public CompletableFuture<ConcurrentHashMap<String, ArrayList<Object>>> mUpdate( | ||
String index, | ||
String collection, | ||
ArrayList<ConcurrentHashMap<String, Object>> documents, | ||
Boolean waitForRefresh, | ||
Integer retryOnConflict) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bad indentation
public CompletableFuture<ConcurrentHashMap<String, ArrayList<Object>>> updateByQuery( | ||
String index, | ||
String collection, | ||
ConcurrentHashMap<String, Object> searchQuery, | ||
ConcurrentHashMap<String, Object> changes) throws NotConnectedException, InternalException |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bad indentation
public CompletableFuture<ConcurrentHashMap<String, ArrayList<Object>>> updateByQuery( | ||
String index, | ||
String collection, | ||
ConcurrentHashMap<String, Object> searchQuery, | ||
ConcurrentHashMap<String, Object> changes, | ||
Boolean waitForRefresh) throws NotConnectedException, InternalException |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bad indentation
fun upsert( | ||
index: String, | ||
collection: String, | ||
id: String, | ||
changes: ConcurrentHashMap<String, Any?>, | ||
defaults: ConcurrentHashMap<String, Any?>, | ||
waitForRefresh: Boolean? = null, | ||
retryOnConflict: Int? = null, | ||
source: Boolean? = null): CompletableFuture<ConcurrentHashMap<String, Any?>> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bad indentation
if (defaults != null) { | ||
|
||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Useless code
kuzzle | ||
.documentController | ||
.upsert("nyc-open-data", "yellow-taxi", "some-id", changes) | ||
.get() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing indentation
What does this PR do ?
Add document:upsert #37
Other changes
Revert wrong change on
build.gradle.kts
Fix mUpdate and updateByQuery doc
Boyscout