Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ConcurrentHashMap by Map #43

Merged
merged 13 commits into from
Feb 5, 2021
Merged

Replace ConcurrentHashMap by Map #43

merged 13 commits into from
Feb 5, 2021

Conversation

jenow
Copy link
Contributor

@jenow jenow commented Feb 3, 2021

What does this PR do ?

Use the Map interface instead of ConcurrentHashMap to let the developer choose what kind of Map to use.

@jenow jenow self-assigned this Feb 3, 2021
Leodau
Leodau approved these changes Feb 4, 2021
View reviewed changes
Copy link
Contributor

@Leodau Leodau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get a better description on why this refactor was priority/necessary?

@jenow
Copy link
Contributor Author

jenow commented Feb 4, 2021

Can we get a better description on why this refactor was priority/necessary?

Somone from the community pointed out that instead of using the Map interface we are using a specialized map so it could be blocking for some peope. Since it approximately take only a mass replace on the project I did it.

@Yoann-Abbes Yoann-Abbes merged commit 50b1a40 into master Feb 5, 2021
@Yoann-Abbes Yoann-Abbes deleted the map-port branch February 5, 2021 15:43
@Yoann-Abbes Yoann-Abbes mentioned this pull request Feb 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yoann-Abbes Yoann-Abbes Yoann-Abbes approved these changes

@Leodau Leodau Leodau approved these changes

Assignees

@jenow jenow

Labels
changelog:enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jenow @Leodau @Yoann-Abbes