Add Gradle task to build a thin jar for Android/Kotlin project #45
Conversation
| ::: warning | ||
| If you have duplicates dependencies issues, you should either add those lines in your application `gradle.build file` | ||
|
|
||
| ```groovy | ||
| configurations { | ||
| cleanedAnnotations | ||
| compile.exclude group: 'org.jetbrains' | ||
| compile.exclude group: 'org.jetbrains.kotlin' | ||
| } | ||
| ``` | ||
|
|
||
| Or you can use our jar dependencies less, and add those dependencies in your application: | ||
|
|
||
| ```groovy | ||
| implementation("io.ktor:ktor-client-websockets:1.5.2") | ||
| implementation("io.ktor:ktor-client-okhttp:1.5.2") | ||
| implementation("io.ktor:ktor-client-cio:1.5.2") | ||
| implementation("io.ktor:ktor-client-json:1.5.2") | ||
| implementation("io.ktor:ktor-client-gson:1.5.2") | ||
| implementation("io.ktor:ktor-client-serialization:1.5.2") | ||
| implementation("com.google.code.gson:gson:2.8.5") | ||
| ``` | ||
|
|
||
| ::: |
There was a problem hiding this comment.
::: warning
If you are using the sdk-jvm-X.Y.Z-with-dependencies.jar in a Kotlin Android Studio project, consider adding the following lines to your gradle.build file
configurations {
cleanedAnnotations
compile.exclude group: 'org.jetbrains'
compile.exclude group: 'org.jetbrains.kotlin'
}:::
::: warning
If you are having troubles with duplicate dependencies in your project, consider using the sdk-jvm-X.Y.Z-without-dependencies.jar and add the following dependencies yourself without the ones that are causing the duplication error:
implementation("io.ktor:ktor-client-websockets:1.5.2")
implementation("io.ktor:ktor-client-okhttp:1.5.2")
implementation("io.ktor:ktor-client-cio:1.5.2")
implementation("io.ktor:ktor-client-json:1.5.2")
implementation("io.ktor:ktor-client-gson:1.5.2")
implementation("io.ktor:ktor-client-serialization:1.5.2")
implementation("com.google.code.gson:gson:2.8.5"):::
|
In the Readme you should also update the dependencies and explain the workaround with the config in the |
Co-authored-by: Shiranuit <[email protected]>
Co-authored-by: Shiranuit <[email protected]>
Co-authored-by: Shiranuit <[email protected]>
Co-authored-by: Shiranuit <[email protected]>
Co-authored-by: Shiranuit <[email protected]>
It's already done |
Co-authored-by: Shiranuit <[email protected]>
Co-authored-by: Shiranuit <[email protected]>
|
I removed the |
What does this PR do ?
Deliver a thin jar for Android Kotlin projects.
Change Getting Started Kotlin
Add Bintray publication for the thin jar
How should this be manually tested?
The thin jar is built by default with
./gradlew buildTo build the fatJar use
./gradlew fatJarInitialize an Android/Kotlin project.
Add the fat jar as dependencies.
You should have "duplicate dependencies" issue.
Try to resolve it by adding those line to your application
gradle.buildfile:configurations { cleanedAnnotations compile.exclude group: 'org.jetbrains' compile.exclude group: 'org.jetbrains.kotlin' }If it does not resolve the problem add the thin jar, and add those dependencies in your application:
Resolves #34
Other Change
Bump
ktorversion from 1.3.2 to 1.5.2Boyscout
Fix Server Controller documentation