Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New API controller: server #5

Merged
merged 5 commits into from
Jul 23, 2020
Merged

New API controller: server #5

merged 5 commits into from
Jul 23, 2020

Conversation

Yoann-Abbes
Copy link
Contributor

@Yoann-Abbes Yoann-Abbes commented Jun 25, 2020 •
edited by jenow
Loading

What does this PR do ?

Add Server controller fix #8

  • adminExists

  • getAllStats

  • getConfig

  • getLastStats

  • getStats

  • info

  • now

@Yoann-Abbes Yoann-Abbes self-assigned this Jun 25, 2020
@Yoann-Abbes Yoann-Abbes marked this pull request as draft June 25, 2020 14:34
@Yoann-Abbes Yoann-Abbes marked this pull request as ready for review July 2, 2020 13:37
@Yoann-Abbes Yoann-Abbes requested a review from jenow July 2, 2020 14:32
jenow
jenow suggested changes Jul 7, 2020
View reviewed changes
Copy link
Contributor

@jenow jenow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great but IMHO I think you should use a Date instead of Timestamp in Kotlin so we don't have to use java.sql.Timestamp but java.util.Date which is more standard.

@Yoann-Abbes Yoann-Abbes requested a review from jenow July 19, 2020 03:00
@scottinet scottinet changed the title Server Controller New API controller: server Jul 22, 2020
@scottinet scottinet merged commit e05bbb6 into 1-dev Jul 23, 2020
@scottinet scottinet deleted the server-controller branch July 23, 2020 15:58
@scottinet scottinet mentioned this pull request Aug 4, 2020
Closed
@jenow jenow mentioned this pull request Nov 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottinet scottinet scottinet approved these changes

@jenow jenow jenow approved these changes

Assignees

@Yoann-Abbes Yoann-Abbes

Labels
changelog:new-features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yoann-Abbes @jenow @scottinet