Fix freeze on reconnection attempts #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yoann-Abbes
reviewed
Apr 20, 2021
| @@ -21,6 +21,7 @@ import java.net.ConnectException | |||
| import java.net.SocketException | |||
| import java.util.concurrent.CompletableFuture | |||
| import java.util.concurrent.ConcurrentLinkedQueue | |||
| import java.util.concurrent.atomic.AtomicBoolean | |||
There was a problem hiding this comment.
Why is a simple boolean not sufficient?
There was a problem hiding this comment.
Because we are doing the check in an other thread (CompletableFuture) which means we need an AtomicBoolean to avoid race conditions with the disconnect method that might be call from a different thread
jenow
approved these changes
Apr 21, 2021
Yoann-Abbes
approved these changes
Apr 23, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
This PR aims to fix a bug that occurs when trying to reconnect and that freezes the SDK during the reconnection
tryToReconnectnow returns aCompletableFuture<Boolean>instead of aBooleanOther