Add Http protocol #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aschen
reviewed
Feb 18, 2022
Shiranuit
suggested changes
Mar 7, 2022
| @@ -3,6 +3,10 @@ description: Run Snippets Testss | |||
| runs: | |||
| using: "composite" | |||
| steps: | |||
| - uses: actions/setup-java@v1 | |||
| with: | |||
| java-version: "11" | |||
There was a problem hiding this comment.
It should be putted somewhere that we are upgrading to Java 11, because people that are using Java 8 wont be able to use the SDK.
Also it is possible to make HTTP Requests using Java 8
doc/1/controllers/auth/check-rights/snippets/check-rights-java.test.yml
Outdated
Show resolved
Hide resolved
doc/1/controllers/auth/check-rights/snippets/check-rights-kotlin.test.yml
Outdated
Show resolved
Hide resolved
| return | ||
| } | ||
| // if state is NOT open, return response to /_publicApi | ||
| this.request.uri(URI.create("http://localhost:7512/_publicApi")) |
There was a problem hiding this comment.
You should test the _query endpoint instead using a POST request
This reverts commit 968cd6f.
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Http protocol support
How should this be manually tested?
Other changes
updated openjdk8 to 11 for all CI