Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize snippet build #72

Merged
merged 6 commits into from
Dec 29, 2022
Merged

Optimize snippet build #72

merged 6 commits into from
Dec 29, 2022

Conversation

Shiranuit
Copy link
Contributor

@Shiranuit Shiranuit commented Apr 4, 2022

What does this PR do ?

This PR tries to reduce the snippet testing time, by compiling every snippets scenario in one executable instead of compiling them each time and spending time in compilation between each tests

This is a Proof of Concept and might not be adopted.

The goal is to compile each snippets inside one file, the way this is achieved is by creating a function for each snippet scenario
and the main function is calling the appropriate function based on an environment variable.
This reduces compilation time to one time instead of having to relaunch the gradle daemon for each step.

The testing time has been reduced by 30%.

Another way to reduce testing time is to launch tests in parallel, some work is currently done to test how this could be achieved

@Shiranuit Shiranuit self-assigned this Apr 4, 2022
@Shiranuit Shiranuit marked this pull request as draft April 4, 2022 09:44
@Shiranuit Shiranuit marked this pull request as ready for review August 31, 2022 12:51
Copy link

@Aschen Aschen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in to test this new approach 👍

@Aschen Aschen merged commit 1feab19 into 1-dev Dec 29, 2022
@Aschen Aschen deleted the optimize-snippet-build branch December 29, 2022 21:14
@Shiranuit Shiranuit mentioned this pull request Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants